Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:60292 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755217Ab3J2NoK (ORCPT ); Tue, 29 Oct 2013 09:44:10 -0400 Date: Tue, 29 Oct 2013 09:44:08 -0400 To: Hellwig Christoph Cc: "Myklebust, Trond" , "Schumaker, Bryan" , Mailing List Linux NFS Subject: Re: [PATCH 2/3] NFS: Allow for asynchronous WRITE_PLUS calls Message-ID: <20131029134408.GH29606@fieldses.org> References: <1382972418-2249-1-git-send-email-bjschuma@netapp.com> <1382972418-2249-3-git-send-email-bjschuma@netapp.com> <20131029073943.GD10889@infradead.org> <20131029124836.GA13482@infradead.org> <58212CB2-A01A-43F1-8760-5ED8ED75E081@netapp.com> <20131029130857.GB32094@infradead.org> <78317EB5-0325-429B-89C8-F4092B677EC4@netapp.com> <20131029132421.GA13880@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20131029132421.GA13880@infradead.org> From: "J. Bruce Fields" Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Oct 29, 2013 at 06:24:21AM -0700, Hellwig Christoph wrote: > On Tue, Oct 29, 2013 at 01:21:26PM +0000, Myklebust, Trond wrote: > > The current draft spec even allows the client to specify a "pattern" to be written to the "hole". > > That's indeed the WRITE SAME lookalike then. At least the SCSI people > were smart enough to define an unmap bit for "hole punching" and allow > the target to reject all other versions if they don't want to support > it. > > Given that NFS v4.2 isn't finalized I'd very much recommend to > > a) properly separate those case s > b) do not make the async version mandatory That sounds reasonable to me. By the way, source is available from https://github.com/loghyr/NFSv4.2, and Tom takes patches..... (Or maybe Anna can be talked into that.) --b.