Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:14799 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753520Ab3KKS6Z (ORCPT ); Mon, 11 Nov 2013 13:58:25 -0500 Message-ID: <5281290B.6000201@RedHat.com> Date: Mon, 11 Nov 2013 13:59:23 -0500 From: Steve Dickson MIME-Version: 1.0 To: Chuck Lever CC: "Myklebust, Trond" , Linux NFS Mailing List Subject: Re: [PATCH] Adding the nfs4_secure_mounts bool References: <1384037221-7224-1-git-send-email-steved@redhat.com> <52811CBB.3070204@RedHat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 11/11/13 13:30, Chuck Lever wrote: > > On Nov 11, 2013, at 1:06 PM, Steve Dickson wrote: > >> >> >> On 09/11/13 18:12, Myklebust, Trond wrote: >>> One alternative to the above scheme, which I believe that I?ve >>> suggested before, is to have a permanent entry in rpc_pipefs >>> that rpc.gssd can open and that the kernel can use to detect >>> that it is running. If we make it /var/lib/nfs/rpc_pipefs/gssd/clnt00/gssd, >>> then AFAICS we don?t need to change nfs-utils at all, since all newer >>> versions of rpc.gssd will try to open for read anything of the form >>> /var/lib/nfs/rpc_pipefs/*/clntXX/gssd... >> >> After further review I am going going have to disagree with you on this. >> Since all the context is cached on the initial mount the kernel >> should be using the call_usermodehelper() to call up to rpc.gssd >> to get the context, which means we could put this upcall noise >> to bed... forever! :-) > > Ask Al Viro for his comments on whether the kernel should start > gssd (either a daemon or a script). Hint: wear your kevlar underpants. I was thinking gssd would become a the gssd-cmd command... Al does not like the call_usermodehelper() interface? > > Have you tried Trond's approach yet? Looking into it... But nothing is trivial in that code... > >> I realize this is not going happen overnight, so I would still >> like to propose my nfs4_secure_mounts bool patch as bridge >> to the new call_usermodehelper() since its the cleanest >> solution so far... >> >> Thoughts? > > We have workarounds already that work on every kernel since 3.8. > The one that logs 5 to 20 lines (depending on thins are setup or not) per mount? That does work in some environments but no all. ;-) Or am I missing one? Please tell me I am!!! :-) steved.