Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:60301 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965Ab3KBOvI (ORCPT ); Sat, 2 Nov 2013 10:51:08 -0400 Date: Sat, 2 Nov 2013 07:51:05 -0700 From: Christoph Hellwig To: "J. Bruce Fields" Cc: Christoph Hellwig , Anna Schumaker , linux-nfs@vger.kernel.org Subject: Re: [PATCH 3/4] NFSD: Add WRITE_PLUS support for hole punches Message-ID: <20131102145105.GA4450@infradead.org> References: <1382972247-1108-1-git-send-email-bjschuma@netapp.com> <1382972247-1108-4-git-send-email-bjschuma@netapp.com> <20131028214030.GO31322@fieldses.org> <526FAF30.3060502@netapp.com> <20131029130649.GA29606@fieldses.org> <20131102135409.GC18961@infradead.org> <20131102144431.GB26983@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20131102144431.GB26983@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Sat, Nov 02, 2013 at 10:44:31AM -0400, J. Bruce Fields wrote: > On Sat, Nov 02, 2013 at 06:54:09AM -0700, Christoph Hellwig wrote: > > On Tue, Oct 29, 2013 at 09:06:49AM -0400, J. Bruce Fields wrote: > > > What I meant was--why are we doing a sync at all, instead of returning > > > NFS_UNSTABLE and making the client commit? > > > > Did NFSv4.2 introduce a concept of unstable metadata operations? > > No, but I think WRITE_PLUS does have a stable/unstable bit so I think we > could choose not to do the sync if that'd make sense. Both operations are idempotent, so supporting it shouldn't be a major obstactle. But suddenly having some metadata operations that can be unstable seems like a major wart in the spec.