Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:41174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171Ab3KRQyE (ORCPT ); Mon, 18 Nov 2013 11:54:04 -0500 Date: Mon, 18 Nov 2013 11:53:59 -0500 From: Jeff Layton To: "Myklebust, Trond" Cc: Bruce Fields , Steve Dickson , "Linux NFS Mailing List" Subject: Re: [PATCH 2/2] gssd: don't let parent exit until child has a chance to scan directory once Message-ID: <20131118115359.21e5f562@tlielax.poochiereds.net> In-Reply-To: References: <1384542931-18753-1-git-send-email-jlayton@redhat.com> <1384542931-18753-3-git-send-email-jlayton@redhat.com> <20131118163829.GC3203@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, 18 Nov 2013 16:48:14 +0000 "Myklebust, Trond" wrote: > > On Nov 18, 2013, at 11:38, J. Bruce Fields wrote: > > > On Fri, Nov 15, 2013 at 02:15:31PM -0500, Jeff Layton wrote: > >> With some proposed kernel changes, it won't even attempt to upcall > >> sometimes if it doesn't appear that gssd is running. This means that > >> we have a theoretical race between gssd starting up at boot time and > >> the init process attempting to mount kerberized filesystems. > >> > >> Fix this by switching gssd to use mydaemon() and having the child > >> only release the parent after it has processed the directory once. > > > > Makes sense to me, thanks--ACK. > > We now appear to have 2 more or less identical copies of mydaemon in nfs-utils (one in utils/gssd/svcgssd.c and one in utils/idmapd/idmapd.c). Time to make it a common library function? > See patch 1 in the series. That's exactly what I did... -- Jeff Layton