Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:63347 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755212AbaADP21 (ORCPT ); Sat, 4 Jan 2014 10:28:27 -0500 Subject: Re: [RFC PATCH 1/5] sunrpc: don't wait for write before allowing reads from use-gss-proxy file From: Simo Sorce To: "J. Bruce Fields" Cc: Jeff Layton , linux-nfs@vger.kernel.org, neilb@suse.de In-Reply-To: <20140103223451.GE5164@fieldses.org> References: <1388579314-15255-1-git-send-email-jlayton@redhat.com> <1388579314-15255-2-git-send-email-jlayton@redhat.com> <20140102212149.GC28219@fieldses.org> <20140102172651.559eaa48@tlielax.poochiereds.net> <20140102224009.GF28219@fieldses.org> <20140102182746.547964c0@tlielax.poochiereds.net> <1388736843.26102.33.camel@willson.li.ssimo.org> <20140103162319.GK28219@fieldses.org> <1388786760.26102.65.camel@willson.li.ssimo.org> <20140103223451.GE5164@fieldses.org> Content-Type: text/plain; charset="UTF-8" Date: Sat, 04 Jan 2014 10:28:22 -0500 Message-ID: <1388849302.26102.66.camel@willson.li.ssimo.org> Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, 2014-01-03 at 17:34 -0500, J. Bruce Fields wrote: > On Fri, Jan 03, 2014 at 05:06:00PM -0500, Simo Sorce wrote: > > I'd like to use sd_notify, but preferred a more conservative approach > > for wider distribution portability. > > > > Patch here waiting for review upstream: > > http://fedorapeople.org/cgit/simo/public_git/gss-proxy.git/commit/?h=usermode&id=ddc5eb950bbd2050dc76b4783f3d3383cd89bccf > > Thanks. If it's not too much verbage, it might be helpful to document > the reason for the ordering; something like: > > /* > * We need to tell nfsd gss-proxy is available before it starts, > * as nfsd may need to know this the moment it receives the > * first init_sec_context call. > * > * So now it is safe to tell the init system that we're done > * starting up and that it can continue with nfsd startup. > */ > > ? Good idea, I changed the comments loosely after your example: http://fedorapeople.org/cgit/simo/public_git/gss-proxy.git/commit/?h=usermode&id=393570b45816b690cb16fd1286d0705142ef2d62 Simo. -- Simo Sorce * Red Hat, Inc * New York