Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-ie0-f170.google.com ([209.85.223.170]:62619 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbaATE3B convert rfc822-to-8bit (ORCPT ); Sun, 19 Jan 2014 23:29:01 -0500 Received: by mail-ie0-f170.google.com with SMTP id u16so6054552iet.29 for ; Sun, 19 Jan 2014 20:28:59 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: [PATCH 2/2] nfs4: fix comments in discover_server_trunking From: Weston Andros Adamson In-Reply-To: <1390189537-9666-2-git-send-email-dros@primarydata.com> Date: Sun, 19 Jan 2014 23:20:52 -0500 Cc: linux-nfs list Message-Id: <044F0EF6-E033-4277-AB83-ACFEA739C188@primarydata.com> References: <1390189537-9666-1-git-send-email-dros@primarydata.com> <1390189537-9666-2-git-send-email-dros@primarydata.com> To: Trond Myklebust Sender: linux-nfs-owner@vger.kernel.org List-ID: Ignore this patch. I misunderstood the meaning of the original comments... -dros On Jan 19, 2014, at 10:45 PM, Weston Andros Adamson wrote: > 'result' is not updated if a match isn't found in the > nfs4_discover_server_trunking path. > > Signed-off-by: Weston Andros Adamson > --- > fs/nfs/nfs4client.c | 4 ++-- > fs/nfs/nfs4state.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c > index 0f9b772..147a752 100644 > --- a/fs/nfs/nfs4client.c > +++ b/fs/nfs/nfs4client.c > @@ -465,7 +465,7 @@ static void nfs4_swap_callback_idents(struct nfs_client *keep, > * nfs40_walk_client_list - Find server that recognizes a client ID > * > * @new: nfs_client with client ID to test > - * @result: OUT: found nfs_client, or new > + * @result: OUT: found nfs_client > * @cred: credential to use for trunking test > * > * Returns zero, a negative errno, or a negative NFS4ERR status. > @@ -601,7 +601,7 @@ out_major_mismatch: > * nfs41_walk_client_list - Find nfs_client that matches a client/server owner > * > * @new: nfs_client with client ID to test > - * @result: OUT: found nfs_client, or new > + * @result: OUT: found nfs_client > * @cred: credential to use for trunking test > * > * Returns zero, a negative errno, or a negative NFS4ERR status. > diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c > index e5be725..666512e 100644 > --- a/fs/nfs/nfs4state.c > +++ b/fs/nfs/nfs4state.c > @@ -328,7 +328,7 @@ out: > * nfs41_discover_server_trunking - Detect server IP address trunking (mv1) > * > * @clp: nfs_client under test > - * @result: OUT: found nfs_client, or clp > + * @result: OUT: found nfs_client > * @cred: credential to use for trunking test > * > * Returns NFS4_OK, a negative errno, or a negative NFS4ERR status. > -- > 1.8.3.4 (Apple Git-47) >