Date: Thu, 2 Jan 2014 17:26:51 -0500
From: Jeff Layton <jlayton@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org, simo@redhat.com, neilb@suse.de
Subject: Re: [RFC PATCH 1/5] sunrpc: don't wait for write before allowing
 reads from use-gss-proxy file
Message-ID: <20140102172651.559eaa48@tlielax.poochiereds.net>
In-Reply-To: <20140102212149.GC28219@fieldses.org>
References: <1388579314-15255-1-git-send-email-jlayton@redhat.com>
	<1388579314-15255-2-git-send-email-jlayton@redhat.com>
	<20140102212149.GC28219@fieldses.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-nfs-owner@vger.kernel.org

On Thu, 2 Jan 2014 16:21:50 -0500
"J. Bruce Fields" <bfields@fieldses.org> wrote:

> On Wed, Jan 01, 2014 at 07:28:30AM -0500, Jeff Layton wrote:
> > It doesn't make much sense to make reads from this procfile hang. As
> > far as I can tell, only gssproxy itself will open this file and it
> > never reads from it. Change it to just give the present setting of
> > sn->use_gss_proxy without waiting for anything.
> 
> I think my *only* reason for doing this was to give a simple way to wait
> for gss-proxy to start (just wait for a read to return).
> 

What wasn't clear to me is what would be doing this read.

I'll take it from your comment then that patch #1 is acceptable?

> As long as gss-proxy has some way to say "I'm up and running", and as
> long as that comes after writing to use-gss-proxy, we're fine.
> 

I'll let Simo confirm that that's what gssproxy does, but yes that is
the desired behavior. Typically this is done by ensuring that the parent
process when daemon()-izing doesn't exit until everything is ready.

If gssproxy does need to be changed for that, we have a library routine
now in nfs-utils that does this that you can likely copy (see
mydaemon()).

-- 
Jeff Layton <jlayton@redhat.com>