Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-ie0-f178.google.com ([209.85.223.178]:47535 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752004AbaCFTrv convert rfc822-to-8bit (ORCPT ); Thu, 6 Mar 2014 14:47:51 -0500 Received: by mail-ie0-f178.google.com with SMTP id lx4so3243425iec.37 for ; Thu, 06 Mar 2014 11:47:51 -0800 (PST) Subject: Re: Optimal NFS mount options to safely allow interrupts and timeouts on newer kernels Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Content-Type: text/plain; charset=windows-1252 From: Trond Myklebust In-Reply-To: <1494458922-1394134385-cardhu_decombobulator_blackberry.rim.net-1425882517-@b5.c4.bise6.blackberry> Date: Thu, 6 Mar 2014 14:47:48 -0500 Cc: Andrew Martin , Jim Rees , Brown Neil , linux-nfs-owner@vger.kernel.org, linux-nfs@vger.kernel.org Message-Id: <5B3606E3-01F9-45C5-8733-B424AF5CB8CB@primarydata.com> References: <1696396609.119284.1394040541217.JavaMail.zimbra@xes-inc.com> <260588931.122771.1394041524167.JavaMail.zimbra@xes-inc.com> <20140306145042.6db53f60@notabene.brown> <1853694865.210849.1394082223818.JavaMail.zimbra@xes-inc.com> <20140306163721.0edfb498@notabene.brown> <1709792528-1394084840-cardhu_decombobulator_blackberry.rim.net-1367662481-@b5.c4.bise6.blackberry> <764210708.28409.1394119821635.JavaMail.zimbra@xes-inc.com> <20140306162208.GA18207@umich.edu> <1094203678.52139.1394124222574.JavaMail.zimbra@xes-inc.com> <1028951407-1394132418-cardhu_decombobulator_blackberry.rim.net-599891631-@b5.c4.bise6.blackberry> <745494581-1394133289-cardhu_decombobulator_blackberry.rim.net-1805734207-@b5.c4.bise6.blackberry> <84CFBA83-C2FE-4AA1-92D7-C37EDFC75117@primarydata.com> <1494458922-1394134385-cardhu_decombobulator_blackberry.rim.net-1425882517-@b5.c4.bise6.blackberry> To: bhawley@luminex.com Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mar 6, 2014, at 14:33, Brian Hawley wrote: > > We do call fsync at synchronization points. > > The problem is the write() blocks forever (or for an exceptionally long time on the order of hours and days), even with timeo set to say 20 and retrans set to 2. We see timeout messages in /var/log/messages, but the write continues to pend. Until we start doing repeated umount -f's. Then it returns and has an i/o error. How much data are you trying to sync? ?soft? won?t time out the entire batch at once. It feeds each write RPC call through, and lets it time out. So if you have cached a huge amount of writes, then that can take a while. The solution is to play with the ?dirty_background_bytes? (and/or ?dirty_bytes?) sysctl so that it starts writeback at an earlier time. Also, what is the cause of these stalls in the first place? Is the TCP connection to the server still up? Are any Oopses present in either the client or the server syslogs? > -----Original Message----- > From: Trond Myklebust > Date: Thu, 6 Mar 2014 14:26:24 > To: > Cc: Andrew Martin; Jim Rees; Brown Neil; ; > Subject: Re: Optimal NFS mount options to safely allow interrupts and timeouts on newer kernels > > > On Mar 6, 2014, at 14:14, Brian Hawley wrote: > >> >> Trond, >> >> In this case, it isn't fsync or close that are not getting the i/o error. It is the write(). > > My point is that write() isn?t even required to return an error in the case where your NFS server is unavailable. Unless you use O_SYNC or O_DIRECT writes, then the kernel is entitled and indeed expected to cache the data in its page cache until you explicitly call fsync(). The return value of that fsync() call is what tells you whether or not your data has safely been stored to disk. > >> And we check the return value of every i/o related command. > >> We aren't using synchronous because the performance becomes abysmal. >> >> Repeated umount -f does eventually result in the i/o error getting propagated back to the write() call. I suspect the repeated umount -f's are working their way through blocks in the cache/queue and eventually we get back to the blocked write. >> >> As I mentioned previously, if we mount with sync or direct i/o type options, we will get the i/o error, but for performance reasons, this isn't an option. > > Sure, but in that case you do need to call fsync() before the application exits. Nothing else can guarantee data stability, and that?s true for all storage. > >> -----Original Message----- >> From: Trond Myklebust >> Date: Thu, 6 Mar 2014 14:06:24 >> To: >> Cc: Andrew Martin; Jim Rees; Brown Neil; ; >> Subject: Re: Optimal NFS mount options to safely allow interrupts and timeouts on newer kernels >> >> >> On Mar 6, 2014, at 14:00, Brian Hawley wrote: >> >>> >>> Even with small timeo and retrans, you won't get i/o errors back to the reads/writes. That's been our experience anyway. >> >> Read caching, and buffered writes mean that the I/O errors often do not occur during the read()/write() system call itself. >> >> We do try to propagate I/O errors back to the application as soon as the do occur, but if that application isn?t using synchronous I/O, and it isn?t checking the return values of fsync() or close(), then there is little the kernel can do... >> >>> >>> With soft, you may end up with lost data (data that had already been written to the cache but not yet to the storage). You'd have that same issue with 'hard' too if it was your appliance that failed. If the appliance never comes back, those blocks can never be written. >>> >>> In your case though, you're not writing. >>> >>> >>> -----Original Message----- >>> From: Andrew Martin >>> Date: Thu, 6 Mar 2014 10:43:42 >>> To: Jim Rees >>> Cc: ; NeilBrown; ; >>> Subject: Re: Optimal NFS mount options to safely allow interrupts and >>> timeouts on newer kernels >>> >>>> From: "Jim Rees" >>>> Andrew Martin wrote: >>>> >>>>> From: "Jim Rees" >>>>> Given this is apache, I think if I were doing this I'd use >>>>> ro,soft,intr,tcp >>>>> and not try to write anything to nfs. >>>> I was using tcp,bg,soft,intr when this problem occurred. I do not know if >>>> apache was attempting to do a write or a read, but it seems that >>>> tcp,soft,intr >>>> was not sufficient to prevent the problem. >>>> >>>> I had the impression from your original message that you were not using >>>> "soft" and were asking if it's safe to use it. Are you saying that even with >>>> the "soft" option the apache gets stuck forever? >>> Yes, even with soft, it gets stuck forever. I had been using tcp,bg,soft,intr >>> when the problem occurred (on several ocassions), so my original question was >>> if it would be safe to use a small timeo and retrans values to hopefully >>> return I/O errors quickly to the application, rather than blocking forever >>> (which causes the high load and inevitable reboot). It sounds like that isn't >>> safe, but perhaps there is another way to resolve this problem? >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> _________________________________ >> Trond Myklebust >> Linux NFS client maintainer, PrimaryData >> trond.myklebust@primarydata.com >> > > _________________________________ > Trond Myklebust > Linux NFS client maintainer, PrimaryData > trond.myklebust@primarydata.com > _________________________________ Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com