Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-qc0-f170.google.com ([209.85.216.170]:43137 "EHLO mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755875AbaCKVdY convert rfc822-to-8bit (ORCPT ); Tue, 11 Mar 2014 17:33:24 -0400 Received: by mail-qc0-f170.google.com with SMTP id e9so10315413qcy.15 for ; Tue, 11 Mar 2014 14:33:24 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: [PATCH] nfs: Don't assume we have a security structure From: Trond Myklebust In-Reply-To: <1394572274-16474-1-git-send-email-Anna.Schumaker@netapp.com> Date: Tue, 11 Mar 2014 17:27:44 -0400 Cc: Linux NFS Mailing List , James Morris , Eric Paris Message-Id: <29D9CA49-A493-471B-932B-959AFF96C729@primarydata.com> References: <1394572274-16474-1-git-send-email-Anna.Schumaker@netapp.com> To: Schumaker Anna , David Quigley Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mar 11, 2014, at 17:11, Anna Schumaker wrote: > If the i_security field isn't set then security_dentry_init_security() > won't initialize some of the values used by the security label. This > causes my client to hit a BUG_ON() while encoding a label of size > -2128927414. > > I hit this bug while testing on a client without SELinux installed. > > Signed-off-by: Anna Schumaker > --- > fs/nfs/nfs4proc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c > index b8cd560..994ccc2 100644 > --- a/fs/nfs/nfs4proc.c > +++ b/fs/nfs/nfs4proc.c > @@ -105,6 +105,9 @@ nfs4_label_init_security(struct inode *dir, struct dentry *dentry, > if (nfs_server_capable(dir, NFS_CAP_SECURITY_LABEL) == 0) > return NULL; > > + if (!dir->i_security) > + return NULL; > + > err = security_dentry_init_security(dentry, sattr->ia_mode, > &dentry->d_name, (void **)&label->label, &label->len); > if (err == 0) Hi Anna, This looks like a check that needs to be done by selinux_dentry_init_security() itself. The dir->i_security field is not something that NFS knows about. David, what needs to happen there when dentry->d_parent->i_security (a.k.a. dsec) is NULL? _________________________________ Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com