Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:46411 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754569AbaDXPbS (ORCPT ); Thu, 24 Apr 2014 11:31:18 -0400 Date: Thu, 24 Apr 2014 11:31:16 -0400 From: "J. Bruce Fields" To: Trond Myklebust Cc: Linus Torvalds , Linux NFS Mailing List , Devel FS Linux , Linux Kernel mailing list , Layton Jeff Subject: Re: nfsd bug fixes for 3.15 Message-ID: <20140424153116.GA15459@fieldses.org> References: <20140424062516.GA8891@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote: > Hi Bruce, > > On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields wrote: > > Please pull the following bug fixes for 3.15 from: > > > > git://linux-nfs.org/~bfields/linux.git for-3.15 > > > > Three small nfsd bugfixes (including one locks.c fix for a bug triggered > > only from nfsd). > > > > Jeff's patches are for long-existing problems that became easier to > > trigger since the addition of vfs delegation support. > > > > --b. > > > > ---------------------------------------------------------------- > > J. Bruce Fields (1): > > Revert "nfsd4: fix nfs4err_resource in 4.1 case" > > > > Wait. Why? Have you changed your mind since our previous discussion, or just forgotten it? (Or did I screw up and revert the wrong commit?) See http://mid.gmane.org/ > NFS4ERR_RESOURCE breaks the Linux client. This returns us to pre-3.15 behavior so shouldn't introduce any new breakage. Fundamentally the problem is that we're returning an error in cases that shouldn't succeed, and rather than replacing one incorrect error by another it seemed better to wait for a proper fix. --b.