Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:35781 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030183AbaDSP4s (ORCPT ); Sat, 19 Apr 2014 11:56:48 -0400 Date: Sat, 19 Apr 2014 08:56:46 -0700 From: Christoph Hellwig To: Trond Myklebust Cc: Bruce Fields , linux-nfs@vger.kernel.org Subject: Re: [PATCH 08/70] nfsd4: use state_lock for delegation hashing Message-ID: <20140419155646.GB13579@infradead.org> References: <1397846704-14567-1-git-send-email-trond.myklebust@primarydata.com> <1397846704-14567-2-git-send-email-trond.myklebust@primarydata.com> <1397846704-14567-3-git-send-email-trond.myklebust@primarydata.com> <1397846704-14567-4-git-send-email-trond.myklebust@primarydata.com> <1397846704-14567-5-git-send-email-trond.myklebust@primarydata.com> <1397846704-14567-6-git-send-email-trond.myklebust@primarydata.com> <1397846704-14567-7-git-send-email-trond.myklebust@primarydata.com> <1397846704-14567-8-git-send-email-trond.myklebust@primarydata.com> <1397846704-14567-9-git-send-email-trond.myklebust@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1397846704-14567-9-git-send-email-trond.myklebust@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: > +static void > +hash_delegation_locked(struct nfs4_delegation *dp, struct nfs4_file *fp) > +{ This series adds a lot of _locked function. I would really like to see an assert_spin_locked or equivalent in each of them, to a) prove we got the locking right, and to b) document the needed lock for new code using them.