Message-ID: <535119F0.4010402@gmail.com>
Date: Fri, 18 Apr 2014 20:26:24 +0800
From: Kinglong Mee <kinglongmee@gmail.com>
MIME-Version: 1.0
To: "J. Bruce Fields" <bfields@fieldses.org>,
        Christoph Hellwig <hch@infradead.org>
CC: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: Clear cached acl after setting a zero-length default
 posix acl:
References: <534FCD13.303@gmail.com> <20140417143634.GA20857@infradead.org> <20140418121353.GC18612@fieldses.org>
In-Reply-To: <20140418121353.GC18612@fieldses.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Sender: linux-nfs-owner@vger.kernel.org

On 2014/4/18 20:13, J. Bruce Fields wrote:
> On Thu, Apr 17, 2014 at 07:36:34AM -0700, Christoph Hellwig wrote:
>> On Thu, Apr 17, 2014 at 08:46:11PM +0800, Kinglong Mee wrote:
>>> After setting ACL for directory, I got two problems that caused
>>> by the cached zero-length default posix acl.
>>>
>>> This patch just clears the cached zero-length default posix acl
>>> after setting.
>>>
>>> First problem:
>>> # nfs4_setfacl -s A::OWNER@:RWX /mnt/123/; touch /mnt/123/test
>>> ............ hang ...........
>>
>> Nfsd must not call forget_cached_acl, that's the filesystems job.
>> I think the right fix is to make sure nfsd4_set_nfs4_acl calls ->set_acl
>> with a NULL ACL structure if there are no entries.
>>
>> Btw, it would be really good if we kept tests like this as a regression
>> test suite.  Is there one for NFS already?  If not we could add
>> nfs-specific tests to xfstests as well.
>
> I'd recommend pynfs for something like this.
>
> (It talks NFSv4 directly to the server, so won't depend on client
> acl-caching behavior, etc.)
>

Make sense.
I will try to add some test cases for ACL to pynfs.

Thanks,
Kinglong Mee