Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-yk0-f175.google.com ([209.85.160.175]:39746 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbaE2DlS (ORCPT ); Wed, 28 May 2014 23:41:18 -0400 Received: by mail-yk0-f175.google.com with SMTP id 131so9129647ykp.34 for ; Wed, 28 May 2014 20:41:18 -0700 (PDT) Message-ID: <5386AC52.6080403@gmail.com> Date: Thu, 29 May 2014 11:41:06 +0800 From: Kinglong Mee MIME-Version: 1.0 To: Trond Myklebust CC: Dr James Bruce Fields , Linux NFS Mailing List Subject: Re: [PATCH] SUNRPC: remove KERN_DEFAULT kernel loglevel from dfprintk References: <5386A183.5030405@gmail.com> <5386A803.4080703@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 5/29/2014 11:32, Trond Myklebust wrote: > On Wed, May 28, 2014 at 11:22 PM, Kinglong Mee > wrote: >> On 5/29/2014 11:15, Trond Myklebust wrote: >>> Nack. This is an api change... >> >> API change ? printk ? dprintk? > > dprintk != printk. We have NEVER supported dprintk(KERN_WARNING...) > > Please use one or the other, but don't try to mix APIs. Thank you very much. I will send a new patch for change the using of dprintk(KERN_WARNING...). thanks, Kinglong Mee > >>> >>> On May 28, 2014 10:55 PM, "Kinglong Mee" >> wrote: >>> >>> When debugging, rpc prints messages for dprintk(KERN_WARNING ...) as, >>> >>> [ 2780.339988] ^A4nfsd: connect from unprivileged port: 0000:0000:0000:0000:0000:0000:0000:0001, port=35316 >>> >>> Because, it expends as printk(KERN_DEFAULT KERN_WARNING ...). >> >> net/sunrpc/svcsock.c:852, and fs/nfsd/nfsfh.c:91 call dprintk as, >> dprintk(KERN_WARNING ...) ---> printk(KERN_DEFAULT KERN_WARNING ...) >> >> so that, "^A4" will be prefixed before the debugging message. >> >> thanks, >> Kinglong Mee >> >>> >>> Signed-off-by: Kinglong Mee >> >>> --- >>> include/linux/sunrpc/debug.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h >>> index 9385bd7..742e2ac 100644 >>> --- a/include/linux/sunrpc/debug.h >>> +++ b/include/linux/sunrpc/debug.h >>> @@ -42,14 +42,14 @@ extern unsigned int nlm_debug; >>> # define dfprintk(fac, args...) \ >>> do { \ >>> ifdebug(fac) \ >>> - printk(KERN_DEFAULT args); \ >>> + printk(args); \ >>> } while (0) >>> >>> # define dfprintk_rcu(fac, args...) \ >>> do { \ >>> ifdebug(fac) { \ >>> rcu_read_lock(); \ >>> - printk(KERN_DEFAULT args); \ >>> + printk(args); \ >>> rcu_read_unlock(); \ >>> } \ >>> } while (0) >>> -- >>> 1.9.3 >>> > > > > -- > Trond Myklebust > > Linux NFS client maintainer, PrimaryData > > trond.myklebust@primarydata.com