Message-ID: <537A3A22.4080503@gmail.com>
Date: Mon, 19 May 2014 13:06:42 -0400
From: Anna Schumaker <schumaker.anna@gmail.com>
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>
CC: Weston Andros Adamson <dros@primarydata.com>,
        trond.myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 8/8] pnfs: merge identical functions
References: <1400512508-7530-1-git-send-email-dros@primarydata.com> <1400512508-7530-9-git-send-email-dros@primarydata.com> <20140519153402.GB21345@infradead.org> <537A2D32.1020701@gmail.com> <20140519165732.GB663@infradead.org>
In-Reply-To: <20140519165732.GB663@infradead.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-nfs-owner@vger.kernel.org

On 05/19/2014 12:57 PM, Christoph Hellwig wrote:
> On Mon, May 19, 2014 at 12:11:30PM -0400, Anna Schumaker wrote:
>>> I think it should also be mossible to simply call pnfs_put_lseg
>>> from nfs_pgio_header_free.  pnfs_put_lseg handles a NULL argument fine,
>>> is stubbed out for the non-pnfs case, and the other callers should never
>>> have it set.
>> Every function in this area is identical to each other :).  I'm already working on a patch series that combines these functions (and more!).  It also needs more testing before I can submit, but I can update against these patches first to see if this unlocks other cleanups.
> Yes, pnfs.c has lots of duplication of the classic I/O path.  I don't
> think we need to rush out your patches, but it would be good to get them
> out in the not too far future.
>

Sure.  I won't rush anything, but I'll try not to take too long either.