Return-Path: linux-nfs-owner@vger.kernel.org Received: from smtp.opengridcomputing.com ([72.48.136.20]:37583 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbaENSLh (ORCPT ); Wed, 14 May 2014 14:11:37 -0400 From: "Steve Wise" To: "'Chuck Lever'" Cc: "'J. Bruce Fields'" , "'Linux NFS Mailing List'" , "'linux-rdma'" , "'Tom Tucker'" References: <20140506174621.18208.24242.stgit@build.ogc.int> <20140506174632.18208.28160.stgit@build.ogc.int> <00f901cf6eeb$2ff1f630$8fd5e290$@opengridcomputing.com> <3DAF95F3-22D5-4FC5-8C98-5A440E54DC2F@gmail.com> <53737D15.6020902@opengridcomputing.com> <2AEECADA-4A40-4BF2-866E-7F178D016DDE@gmail.com> In-Reply-To: <2AEECADA-4A40-4BF2-866E-7F178D016DDE@gmail.com> Subject: RE: [PATCH V2 RFC 2/3] svcrdma: Recvfrom changes Date: Wed, 14 May 2014 13:11:40 -0500 Message-ID: <009601cf6f9f$f47b2cb0$dd718610$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-nfs-owner@vger.kernel.org List-ID: > > > >> If you print ch_count, it is 2 for NFS WRITEs from a Linux client, > >> no matter how large the write payload is. Therefore I think the check > >> as it is written is not particularly useful. > > > > Why are there 2? > > The first chunk lists the pages the server is to read, and the second > chunk has the zero pad for XDR alignment. > > If pad optimization is enabled on the client, there is just 1 chunk in > the RPC's Read list. > So the code as it stands violates the RFC by sending 2 chunks? And if I change the server to only consume 1, then everything unaligned will break?