Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:37210 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbaFBQvx (ORCPT ); Mon, 2 Jun 2014 12:51:53 -0400 Date: Mon, 2 Jun 2014 12:51:52 -0400 From: "J. Bruce Fields" To: Steve Wise Cc: "'Devesh Sharma'" , linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, tom@opengridcomputing.com Subject: Re: [PATCH V3] svcrdma: refactor marshalling logic Message-ID: <20140602165151.GA20031@fieldses.org> References: <20140529165532.16349.95248.stgit@build.ogc.int> <000001cf7c07$72e613d0$58b23b70$@opengridcomputing.com> <004101cf7e82$68b58ad0$3a20a070$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <004101cf7e82$68b58ad0$3a20a070$@opengridcomputing.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Jun 02, 2014 at 11:47:58AM -0500, Steve Wise wrote: > > > > Steve > > > > I have not checked the code because I am away from my laptop > > But I assume mlx and mthca is using fmr and cxgb4 is using rdma-read-with-invalidate > which > > has implicit fence. > > > > If invalidate is issued before read is completed its a problem. > > > > You're correct. And this bug appears to be in the current upstream code as well. If an > IB_WR_LOCAL_INV wr is used, it must include IB_SEND_FENCE to fence it until the prior read > completes. > > Good catch! I'll post V4 soon. Any chance that can be handled as a separate patch rather than folded in? (Disclaimer: I've been following the discussion only very superficially.) --b.