Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:58574 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752855AbaF3KkS (ORCPT ); Mon, 30 Jun 2014 06:40:18 -0400 Date: Mon, 30 Jun 2014 03:40:14 -0700 From: Christoph Hellwig To: Jeff Layton Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, Trond Myklebust Subject: Re: [PATCH v2 037/117] nfsd: clean up helper __release_lock_stateid Message-ID: <20140630104014.GA2049@infradead.org> References: <1403810017-16062-1-git-send-email-jlayton@primarydata.com> <1403810017-16062-38-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1403810017-16062-38-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Jun 26, 2014 at 03:12:17PM -0400, Jeff Layton wrote: > From: Trond Myklebust > > Use filp_close instead of open coding. filp_close does a bit more than > just release the locks and put the filp. It also calls ->flush and > dnotify_flush, both of which should be done here anyway. Looks good, Reviewed-by: Christoph Hellwig and this can probably move before the locking changes..