Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-vc0-f176.google.com ([209.85.220.176]:33723 "EHLO mail-vc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbaFEOUt convert rfc822-to-8bit (ORCPT ); Thu, 5 Jun 2014 10:20:49 -0400 Received: by mail-vc0-f176.google.com with SMTP id im17so1204455vcb.7 for ; Thu, 05 Jun 2014 07:20:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <53907B9A.3090802@RedHat.com> References: <539026DB.30502@cn.fujitsu.com> <53907B9A.3090802@RedHat.com> Date: Thu, 5 Jun 2014 10:20:48 -0400 Message-ID: Subject: Re: [PATCH]statd: create statdpath dir if specify the "--with-statdpath=xx" parameter in configure nfs-utils source code From: Trond Myklebust To: Steve Dickson Cc: Ditang Chen , "linux-nfs@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Jun 5, 2014 at 10:15 AM, Steve Dickson wrote: > Hey, > > On 06/05/2014 08:38 AM, Trond Myklebust wrote: >> On Thu, Jun 5, 2014 at 4:14 AM, Ditang Chen wrote: >>> When configure the nfs-utils source code with "--with-statdpath=/foo" parameter， >>> #define NSM_DEFAULT_STATEDIR "/foo" will be generated in support/include/config.h file, >>> but Makefile will not create "/foo" dir. >>> >>> Signed-off-by: chendt.fnst@cn.fujitsu.com >>> --- >>> Makefile.am | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/Makefile.am b/Makefile.am >>> index ae7cd16..5c9ef44 100644 >>> --- a/Makefile.am >>> +++ b/Makefile.am >>> @@ -54,10 +54,10 @@ install-data-hook: >>> touch $(DESTDIR)$(statedir)/xtab; chmod 644 $(DESTDIR)$(statedir)/xtab >>> touch $(DESTDIR)$(statedir)/etab; chmod 644 $(DESTDIR)$(statedir)/etab >>> touch $(DESTDIR)$(statedir)/rmtab; chmod 644 $(DESTDIR)$(statedir)/rmtab >>> - mkdir -p $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak >>> touch $(DESTDIR)$(statedir)/state >>> - chmod go-rwx $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak $(DESTDIR)$(statedir)/state >>> - -chown $(statduser) $(DESTDIR)$(statedir)/sm $(DESTDIR)$(statedir)/sm.bak $(DESTDIR)$(statedir)/state >>> + mkdir -p $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak >>> + chmod go-rwx $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak $(DESTDIR)$(statedir)/state >>> + -chown $(statduser) $(DESTDIR)$(statdpath)/sm $(DESTDIR)$(statdpath)/sm.bak $(DESTDIR)$(statedir)/state >>> >> >> The file 'state' is owned by rpc.statd. Isn't it therefore also >> subject to the --with-statdpath modifier? > --with-statedir and --with-statdpath are basically the same thing. > When --with-statdpath is not specified, its set to the --with-statedir > value, that's why this these mkdir,chmod and chown were not needed. > But I guess if you do want split out the statdpath from the statedir > those mkdir,chmod and chown need to happen. > > >> >> At one point, the Fedora RPM packager even used to put it in >> /var/lib/nfs/statd (as the manpage says it should) although that seems >> to be broken now. >> > It still does... So does RHEL... We have being going that for years... > How is that broken? > My nfs-utils rpms on Fedora seem to be creating /var/lib/nfs/state instead of putting it in the statd subdirectory. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com