Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:32946 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbaF2MF0 (ORCPT ); Sun, 29 Jun 2014 08:05:26 -0400 Date: Sun, 29 Jun 2014 05:05:25 -0700 From: Christoph Hellwig To: Jeff Layton Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, Trond Myklebust Subject: Re: [PATCH v2 014/117] nfsd: Allow struct nfsd4_compound_state to cache the nfs4_client Message-ID: <20140629120525.GB16150@infradead.org> References: <1403810017-16062-1-git-send-email-jlayton@primarydata.com> <1403810017-16062-15-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1403810017-16062-15-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Jun 26, 2014 at 03:11:54PM -0400, Jeff Layton wrote: > From: Trond Myklebust > > This will be used later to accelerate lookups of the clientid. While I've already given my reviewed by I need to get picky again here after reviewing a later patch. The description should clearly state that we only cache it for 4.1+ here so far. Unless something else speaks against that I'd also strongly recommend we move the patch to also cache it for 4.0 right next after this patch.