Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:50862 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbaGORBc (ORCPT ); Tue, 15 Jul 2014 13:01:32 -0400 Date: Tue, 15 Jul 2014 10:01:07 -0700 From: Christoph Hellwig To: Jeff Layton Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH] net: clean up some sparse endianness warnings in ipv6.h Message-ID: <20140715170107.GA1722@infradead.org> References: <1405340746-10678-1-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1405340746-10678-1-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: > #if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) && BITS_PER_LONG == 64 > - const unsigned long *ul = (const unsigned long *)a; > + const __be64 *be = (const __be64 *)a; > > - return (ul[0] | (ul[1] ^ cpu_to_be64(1))) == 0UL; > + return (be[0] | (be[1] ^ cpu_to_be64(1))) == cpu_to_be64(0UL); Do you need the swap for 0UL? I know sparse treats 0 as special, so why wouldn't it treat 0UL special? Or just remove the 0UL postfix, no need for it in a simple comparism. Otherwise looks fine to me.