Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:56488 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbaGJKuV (ORCPT ); Thu, 10 Jul 2014 06:50:21 -0400 Date: Thu, 10 Jul 2014 03:50:19 -0700 From: Christoph Hellwig To: Jeff Layton Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v4 013/100] nfsd: shrink st_access_bmap and st_deny_bmap Message-ID: <20140710105019.GD6935@infradead.org> References: <1404842668-22521-1-git-send-email-jlayton@primarydata.com> <1404842668-22521-14-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1404842668-22521-14-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: > static inline void > set_access(u32 access, struct nfs4_ol_stateid *stp) I suspect it might be a good idea to kill all these wrappers, as doing higher level bitops seems to be benefitial to a lot of the callers.