Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:32876 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbaG3U71 (ORCPT ); Wed, 30 Jul 2014 16:59:27 -0400 Date: Wed, 30 Jul 2014 13:59:26 -0700 From: Christoph Hellwig To: Jeff Layton Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH v3 05/38] nfsd4: use cl_lock to synchronize all stateid idr calls Message-ID: <20140730205926.GC25112@infradead.org> References: <1406684083-19736-1-git-send-email-jlayton@primarydata.com> <1406684083-19736-6-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1406684083-19736-6-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Jul 29, 2014 at 09:34:10PM -0400, Jeff Layton wrote: > Currently, this is serialized by the client_mutex, which is slated for > removal. Add finer-grained locking here. Also, do some cleanup around > find_stateid to prepare for taking references. > > Signed-off-by: Trond Myklebust > Signed-off-by: Benny Halevy > Signed-off-by: Jeff Layton Looks good, Reviewed-by: Christoph Hellwig