Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:40262 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756206AbaGCVf1 (ORCPT ); Thu, 3 Jul 2014 17:35:27 -0400 Date: Thu, 3 Jul 2014 17:35:26 -0400 From: "J. Bruce Fields" To: Jeff Layton Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH v3 015/114] nfsd: Allow struct nfsd4_compound_state to cache the nfs4_client Message-ID: <20140703213526.GG24322@fieldses.org> References: <1404143423-24381-1-git-send-email-jlayton@primarydata.com> <1404143423-24381-16-git-send-email-jlayton@primarydata.com> <20140703203259.GF24322@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140703203259.GF24322@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Jul 03, 2014 at 04:32:59PM -0400, J. Bruce Fields wrote: > On Mon, Jun 30, 2014 at 11:48:44AM -0400, Jeff Layton wrote: > > We want to use the nfsd4_compound_state to cache the nfs4_client in > > order to optimise away extra lookups of the clid. > > > > In the v4.0 case, we use this to ensure that we only have to look up the > > client at most once per compound for each call into lookup_clientid. For > > v4.1+ we set the pointer in the cstate during SEQUENCE processing so we > > should never need to do a search for it. > > The connectathon locking test is failing for me in the nfsv4/krb5i case > as of this commit. > > Which makes no sense to me whatsoever, so it's entirely possible this is > some unrelated problem on my side. I'll let you know when I've figured > out anything more. It's intermittent. I've reproduced it on the previous commit so I know at least that this one isn't at fault. I doubt it's really dependent on krb5i, at most that's probably just making it more likely to reproduce. --b.