Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:33378 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbaG3VIE (ORCPT ); Wed, 30 Jul 2014 17:08:04 -0400 Date: Wed, 30 Jul 2014 14:08:02 -0700 From: Christoph Hellwig To: Jeff Layton Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v3 06/38] nfsd: do filp_close in sc_free callback for lock stateids Message-ID: <20140730210802.GA5964@infradead.org> References: <1406684083-19736-1-git-send-email-jlayton@primarydata.com> <1406684083-19736-7-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1406684083-19736-7-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Jul 29, 2014 at 09:34:11PM -0400, Jeff Layton wrote: > Releasing locks when we unhash the stateid instead of doing so only when > the stateid is actually released will be problematic in later patches > when we need to protect the unhashing with spinlocks. Move it into the > sc_free operation instead. > > Signed-off-by: Jeff Layton Looks good, Reviewed-by: Christoph Hellwig