Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:33186 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754678AbaH0SEV (ORCPT ); Wed, 27 Aug 2014 14:04:21 -0400 Date: Wed, 27 Aug 2014 14:04:16 -0400 From: "J. Bruce Fields" To: Christoph Hellwig Cc: bjschuma@netapp.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 2/3] NFSD: Create nfs v4.2 decode ops Message-ID: <20140827180416.GB13910@fieldses.org> References: <1409152678-7806-1-git-send-email-bjschuma@netapp.com> <1409152678-7806-3-git-send-email-bjschuma@netapp.com> <20140827174231.GA13128@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140827174231.GA13128@infradead.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Aug 27, 2014 at 10:42:31AM -0700, Christoph Hellwig wrote: > On Wed, Aug 27, 2014 at 11:17:57AM -0400, bjschuma@netapp.com wrote: > > From: Anna Schumaker > > > > It's cleaner to introduce everything at once and have the server reply > > with "not supported" than it would be to introduce extra operations when > > implementing a specific one in the middle of the list. > > What prevents a client from calling the new operations on a 4.1 session? fs/nfsd/nfs4xdr.c:nfsd4_opnum_in_range(), which just uses minorversion and the LAST_NFS4?_OP constants. --b.