Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:48251 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678AbaIROm3 (ORCPT ); Thu, 18 Sep 2014 10:42:29 -0400 Date: Thu, 18 Sep 2014 16:42:22 +0200 From: Peter Zijlstra To: NeilBrown Cc: Andrew Morton , Trond Myklebust , Ingo Molnar , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton Subject: Re: [PATCH 1/4] SCHED: add some "wait..on_bit...timeout()" interfaces. Message-ID: <20140918144222.GP2840@worktop.localdomain> References: <20140916051911.22257.24658.stgit@notabene.brown> <20140916053134.22257.28841.stgit@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140916053134.22257.28841.stgit@notabene.brown> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Sep 16, 2014 at 03:31:35PM +1000, NeilBrown wrote: > In commit c1221321b7c25b53204447cff9949a6d5a7ddddc > sched: Allow wait_on_bit_action() functions to support a timeout > > I suggested that a "wait_on_bit_timeout()" interface would not meet my > need. This isn't true - I was just over-engineering. > > Including a 'private' field in wait_bit_key instead of a focused > "timeout" field was just premature generalization. If some other > use is ever found, it can be generalized or added later. > > So this patch renames "private" to "timeout" with a meaning "stop > waiting when "jiffies" reaches or passes "timeout", > and adds two of the many possible wait..bit..timeout() interfaces: > > wait_on_page_bit_killable_timeout(), which is the one I want to use, > and out_of_line_wait_on_bit_timeout() which is a reasonably general > example. Others can be added as needed. > > Signed-off-by: NeilBrown > --- > include/linux/pagemap.h | 2 ++ > include/linux/wait.h | 5 ++++- > kernel/sched/wait.c | 36 ++++++++++++++++++++++++++++++++++++ > mm/filemap.c | 13 +++++++++++++ > 4 files changed, 55 insertions(+), 1 deletion(-) > Acked-by: Peter Zijlstra (Intel)