Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:22960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbaIVTnL (ORCPT ); Mon, 22 Sep 2014 15:43:11 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8MJhBGc003890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 22 Sep 2014 15:43:11 -0400 Message-ID: <54207BCD.70101@RedHat.com> Date: Mon, 22 Sep 2014 15:43:09 -0400 From: Steve Dickson MIME-Version: 1.0 To: Simo Sorce CC: Linux NFS Mailing list Subject: Re: [PATCH 1/2] nfs-service: Added the starting of gssproxy References: <1411413608-16462-1-git-send-email-steved@redhat.com> <1411413608-16462-2-git-send-email-steved@redhat.com> <20140922152603.75005941@willson.usersys.redhat.com> In-Reply-To: <20140922152603.75005941@willson.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 09/22/2014 03:26 PM, Simo Sorce wrote: > On Mon, 22 Sep 2014 15:20:07 -0400 > Steve Dickson wrote: > >> Added the gssproxy.service to both the Wants= and >> Atfers= lines, before the rpc-svcgssd.service. There >> are ConditionPathExists= lines in the rpc-svcgssd.service >> unit which will stop the rpc.svcgssd daemon from >> starting when the gssproxy daemon is already running. >> >> Signed-off-by: Steve Dickson >> --- >> systemd/nfs-server.service | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service >> index 2fa7387..c740fa2 100644 >> --- a/systemd/nfs-server.service >> +++ b/systemd/nfs-server.service >> @@ -2,12 +2,13 @@ >> Description=NFS server and services >> Requires= network.target proc-fs-nfsd.mount rpcbind.target >> Requires= nfs-mountd.service >> -Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service >> rpc-svcgssd.service +Wants=rpc-statd.service nfs-idmapd.service >> +Wants=rpc-gssd.service >> Wants=rpc-statd-notify.service >> >> After= network.target proc-fs-nfsd.mount rpcbind.target >> nfs-mountd.service After= nfs-idmapd.service rpc-statd.service >> -After= rpc-gssd.service rpc-svcgssd.service >> +After= rpc-gssd.service gssproxy.service rpc-svcgssd.service >> Before= rpc-statd-notify.service >> >> Wants=nfs-config.service > > I think you really need to insure that the modules are loaded before > any of the server services are started, perhaps adding a unit file that > exec's modprobe and has "Before: gssproxy.service rpc-svcgssd.service" > in it ? I really don't think its needed... From my testing it appears gssproxy is always being started and rpc.svcgssd is not... Plus, from my understanding... loading module from a service file is a big no no! People were having problems with way back when... steved.