Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-vc0-f178.google.com ([209.85.220.178]:59995 "EHLO mail-vc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbaIANu6 (ORCPT ); Mon, 1 Sep 2014 09:50:58 -0400 Received: by mail-vc0-f178.google.com with SMTP id la4so5515493vcb.37 for ; Mon, 01 Sep 2014 06:50:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1409571154-50408-1-git-send-email-shakilk1729@gmail.com> References: <1409571154-50408-1-git-send-email-shakilk1729@gmail.com> Date: Mon, 1 Sep 2014 09:50:57 -0400 Message-ID: Subject: Re: [PATCH] Next branch: authgss: authgss.c: Fix warnings for uninitizlized variable expire From: Trond Myklebust To: Shakil A Khan Cc: Linux NFS Mailing List , Linux Kernel mailing list , "netdev@vger.kernel.org" , Peter Zijlstra , Paul McKenney , William Andros Adamson , Jeffrey Layton , "David S. Miller" , Bruce Fields Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Sep 1, 2014 at 7:32 AM, Shakil A Khan wrote: > Signed-off-by : Shakil A Khan > --- > net/sunrpc/auth_gss/auth_gss.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > index afb292c..bea0951 100644 > --- a/net/sunrpc/auth_gss/auth_gss.c > +++ b/net/sunrpc/auth_gss/auth_gss.c > @@ -1387,7 +1387,7 @@ gss_key_timeout(struct rpc_cred *rc) > struct gss_cred *gss_cred = container_of(rc, struct gss_cred, gc_base); > struct gss_cl_ctx *ctx; > unsigned long now = jiffies; > - unsigned long expire; > + unsigned long expire = 0; > > rcu_read_lock(); > ctx = rcu_dereference(gss_cred->gc_ctx); > -- > 1.7.1 That would be a compiler bug, not a kernel bug. The kernel code is perfectly correct as it stands, and will never access the uninitialised variable. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com