Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:6563 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbaIVTqx (ORCPT ); Mon, 22 Sep 2014 15:46:53 -0400 Date: Mon, 22 Sep 2014 15:46:42 -0400 From: Simo Sorce To: "J. Bruce Fields" Cc: Steve Dickson , Linux NFS Mailing list Subject: Re: [PATCH 1/2] nfs-service: Added the starting of gssproxy Message-ID: <20140922154642.779189c8@willson.usersys.redhat.com> In-Reply-To: <20140922194057.GE26763@fieldses.org> References: <1411413608-16462-1-git-send-email-steved@redhat.com> <1411413608-16462-2-git-send-email-steved@redhat.com> <20140922194057.GE26763@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, 22 Sep 2014 15:40:57 -0400 "J. Bruce Fields" wrote: > On Mon, Sep 22, 2014 at 03:20:07PM -0400, Steve Dickson wrote: > > Added the gssproxy.service to both the Wants= and > > Atfers= lines, before the rpc-svcgssd.service. There > > are ConditionPathExists= lines in the rpc-svcgssd.service > > unit which will stop the rpc.svcgssd daemon from > > starting when the gssproxy daemon is already running. > > That should read "when the kernel supports gssproxy", not "when the > gssproxy daemon is already running." Actually the language is currently correct but it is another bug, the systemd/rpc-svcgssd.service file still includes "ConditionPathExists=|!/run/gssproxy.pid" This line should be removed in this patch. Simo. > --b. > > > > > Signed-off-by: Steve Dickson > > --- > > systemd/nfs-server.service | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service > > index 2fa7387..c740fa2 100644 > > --- a/systemd/nfs-server.service > > +++ b/systemd/nfs-server.service > > @@ -2,12 +2,13 @@ > > Description=NFS server and services > > Requires= network.target proc-fs-nfsd.mount rpcbind.target > > Requires= nfs-mountd.service > > -Wants=rpc-statd.service nfs-idmapd.service rpc-gssd.service > > rpc-svcgssd.service +Wants=rpc-statd.service nfs-idmapd.service > > +Wants=rpc-gssd.service gssproxy.service rpc-svcgssd.service > > Wants=rpc-statd-notify.service > > > > After= network.target proc-fs-nfsd.mount rpcbind.target > > nfs-mountd.service After= nfs-idmapd.service rpc-statd.service > > -After= rpc-gssd.service rpc-svcgssd.service > > +After= rpc-gssd.service gssproxy.service rpc-svcgssd.service > > Before= rpc-statd-notify.service > > > > Wants=nfs-config.service > > -- > > 1.9.3 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-nfs" in the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Simo Sorce * Red Hat, Inc * New York