Return-Path: linux-nfs-owner@vger.kernel.org Received: from bombadil.infradead.org ([198.137.202.9]:59313 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754893AbaIDRqN (ORCPT ); Thu, 4 Sep 2014 13:46:13 -0400 Date: Thu, 4 Sep 2014 10:46:12 -0700 From: Christoph Hellwig To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, Christoph Hellwig , "J. Bruce Fields" , linux-kernel@vger.kernel.org, Trond Myklebust , Steven Whitehouse , cluster-devel@redhat.com Subject: Re: [PATCH v2 01/17] locks: consolidate "nolease" routines Message-ID: <20140904174612.GA16935@infradead.org> References: <1409834323-7171-1-git-send-email-jlayton@primarydata.com> <1409834323-7171-2-git-send-email-jlayton@primarydata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1409834323-7171-2-git-send-email-jlayton@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Sep 04, 2014 at 08:38:27AM -0400, Jeff Layton wrote: > GFS2 and NFS have setlease routines that always just return -EINVAL. > Turn that into a generic routine that can live in fs/libfs.c. Looks good, Reviewed-by: Christoph Hellwig