Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:41323 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbaIWTvt (ORCPT ); Tue, 23 Sep 2014 15:51:49 -0400 Date: Tue, 23 Sep 2014 15:51:48 -0400 From: "J. Bruce Fields" To: Simo Sorce Cc: Steve Dickson , Linux NFS Mailing list Subject: Re: [PATCH 1/2] nfs-service: Added the starting of gssproxy Message-ID: <20140923195148.GM29932@fieldses.org> References: <54207BCD.70101@RedHat.com> <20140922204401.GI26763@fieldses.org> <5420911D.6080506@RedHat.com> <20140922173239.05c17b2a@willson.usersys.redhat.com> <5420A946.4090805@RedHat.com> <20140922201927.36fae05c@willson.usersys.redhat.com> <5420CA96.6090409@RedHat.com> <20140923085245.007533b6@willson.usersys.redhat.com> <20140923192909.GJ29932@fieldses.org> <20140923154036.23e0e639@willson.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140923154036.23e0e639@willson.usersys.redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Sep 23, 2014 at 03:40:36PM -0400, Simo Sorce wrote: > On Tue, 23 Sep 2014 15:29:09 -0400 > "J. Bruce Fields" wrote: > > > On Tue, Sep 23, 2014 at 08:52:45AM -0400, Simo Sorce wrote: > > > It will not, but right now gssproxy.service also has: > > > Requires=proc-fs-nfsd.mount > > > > > > I want to drop this one. > > > > By the way, I think all you actually want is After=proc-fs-nfsd.mount. > > > > You don't actually want to bail out if fs-nfsd.mount fails, in fact > > you don't care if it's activated at all, all you care about is that > > *if* it's already activated (because nfsd is), then you want it to > > start before you. > > > > And in fact we could instead replace that with a > > Before=gssproxy.service in proc-fs-nfsd.mount if you preferred. I > > don't know how to decide which place it goes, or if it matters. > > Given we are already messing with service files I wouldn't object to > moving the depenecy chain creation in nfs-util by adding a > Before=gssproxy.service directive in proc-fs-nfsd.mount and dropping > the Reuire from gssproxy.service Wella ctually we should add the auth-rpcgss unit (which includes the necessary Before). But you might want to s/Requires=/After=/ meanwhile as the current thing seems possibly unreliable (since there's no ordering dependency). --b.