Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-ie0-f174.google.com ([209.85.223.174]:54929 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753412AbaIYR1h convert rfc822-to-8bit (ORCPT ); Thu, 25 Sep 2014 13:27:37 -0400 Received: by mail-ie0-f174.google.com with SMTP id rd18so8495078iec.5 for ; Thu, 25 Sep 2014 10:27:37 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: WARNING at fs/nfs/write.c:743 nfs_inode_remove_request with -rc6 From: Weston Andros Adamson In-Reply-To: <20140925171545.GR20043@arm.com> Date: Thu, 25 Sep 2014 13:27:35 -0400 Cc: Peng Tao , Trond Myklebust , linux-nfs list , "linux-kernel@vger.kernel.org" Message-Id: <78B8153D-59B7-4DBE-8472-D83338F04338@primarydata.com> References: <20140923130352.GK26472@arm.com> <2A327753-3E60-46AC-8220-3FF0FF61F08F@primarydata.com> <20140923135938.GB28608@arm.com> <20140923145356.GD28608@arm.com> <5294BEB2-F20F-4E3E-BFB2-E41806A4F85A@primarydata.com> <20140923152558.GG28608@arm.com> <20140925171545.GR20043@arm.com> To: Will Deacon Sender: linux-nfs-owner@vger.kernel.org List-ID: On Sep 25, 2014, at 1:15 PM, Will Deacon wrote: > Hi Andros, > > On Tue, Sep 23, 2014 at 04:25:58PM +0100, Will Deacon wrote: >> On Tue, Sep 23, 2014 at 04:08:36PM +0100, Weston Andros Adamson wrote: >>> On Sep 23, 2014, at 11:02 AM, Weston Andros Adamson wrote: >>>> Wait a second - the whole point of this extra reference (that the >>>> WARN_ON_ONCE is related to) is to handle the pass off to commit lists. >>>> >>>> Maybe I?m just doing the wrong thing here with NFSv2! >>>> >>>> More soon. >>> >>> Actually, can you see if this is reproducible with NFSv3? >> >> Just tried that, and I'm unable to trigger the problem with NFSv3. > > Any more ideas? I can run with NFSv3 instead, but it's a shame to leave > v2 broken. Hi Will, I do plan on looking at this more very soon, but since it?s v2 only and just warning (and not crashing anything) it didn?t jump to the top of my list. It is only printing the warnings, right? That?s no reason to switch things up ;) It might be interesting to get some rpcdebug output around the time of the warning, but I?m not sure it will be useful. Since I cannot reproduce this, my next step is to inspect the code with an NFSv2 with 64k pages setup in mind. -dros