Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:27396 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbaIVUCf (ORCPT ); Mon, 22 Sep 2014 16:02:35 -0400 Message-ID: <54208058.4060502@RedHat.com> Date: Mon, 22 Sep 2014 16:02:32 -0400 From: Steve Dickson MIME-Version: 1.0 To: Simo Sorce CC: "J. Bruce Fields" , Linux NFS Mailing list Subject: Re: [PATCH 1/2] nfs-service: Added the starting of gssproxy References: <1411413608-16462-1-git-send-email-steved@redhat.com> <1411413608-16462-2-git-send-email-steved@redhat.com> <20140922194057.GE26763@fieldses.org> <20140922154642.779189c8@willson.usersys.redhat.com> <54207E4A.7010300@RedHat.com> <20140922160050.0b85f044@willson.usersys.redhat.com> In-Reply-To: <20140922160050.0b85f044@willson.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 09/22/2014 04:00 PM, Simo Sorce wrote: > On Mon, 22 Sep 2014 15:53:46 -0400 > Steve Dickson wrote: > >> >> >> On 09/22/2014 03:46 PM, Simo Sorce wrote: >>> On Mon, 22 Sep 2014 15:40:57 -0400 >>> "J. Bruce Fields" wrote: >>> >>>> On Mon, Sep 22, 2014 at 03:20:07PM -0400, Steve Dickson wrote: >>>>> Added the gssproxy.service to both the Wants= and >>>>> Atfers= lines, before the rpc-svcgssd.service. There >>>>> are ConditionPathExists= lines in the rpc-svcgssd.service >>>>> unit which will stop the rpc.svcgssd daemon from >>>>> starting when the gssproxy daemon is already running. >>>> >>>> That should read "when the kernel supports gssproxy", not "when the >>>> gssproxy daemon is already running." >>> >>> Actually the language is currently correct but it is another bug, >>> the systemd/rpc-svcgssd.service file still includes >>> "ConditionPathExists=|!/run/gssproxy.pid" >>> This line should be removed in this patch. >> >> I left that on purpose because isn't that ConditionPathExists >> seeing if /run/gssproxy.pid exists and if it does >> it means gssproxy is already running so rpc.svcgssd >> should not start? > > No. > First of all the fact gss-proxy is running does not mean it is > serving nfsd necessarily, it may be running on an older kernel where it > servers apache or some other process (remember gssproxy is not just > for nfsd). > Second you already have > "ConditionPathExists=|!/proc/net/rpc/use-gss-proxy" which is the > correct trigger to decide which of the two to use. Fair enough... that makes sense... steved. > > Simo. >