Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-ig0-f175.google.com ([209.85.213.175]:53178 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbaJMP2j convert rfc822-to-8bit (ORCPT ); Mon, 13 Oct 2014 11:28:39 -0400 Received: by mail-ig0-f175.google.com with SMTP id uq10so10823930igb.14 for ; Mon, 13 Oct 2014 08:28:39 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH 1/1] NFSv4: open context can be NULL in nfs_put_open_context From: Weston Andros Adamson In-Reply-To: Date: Mon, 13 Oct 2014 11:28:39 -0400 Cc: linux-nfs list Message-Id: <0F0C9142-A812-4D91-8AF4-F938A303B874@primarydata.com> References: <1413209295-13509-1-git-send-email-andros@netapp.com> To: Trond Myklebust Sender: linux-nfs-owner@vger.kernel.org List-ID: On Oct 13, 2014, at 11:25 AM, Trond Myklebust wrote: > Resending to list... Apologies for the duplicate... > > On Mon, Oct 13, 2014 at 11:24 AM, Trond Myklebust > wrote: >> Hi Andy, >> >> >> On Mon, Oct 13, 2014 at 10:08 AM, wrote: >>> >>> From: Andy Adamson >>> >>> If a pgio error is caught before the nfs_pgio_header args->context is set >>> with get_nfs_open_context, the context can be NULL. >>> >>> Signed-off-by: Andy Adamson >>> --- >>> fs/nfs/inode.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c >>> index 141c9f4..a2b148e 100644 >>> --- a/fs/nfs/inode.c >>> +++ b/fs/nfs/inode.c >>> @@ -798,6 +798,9 @@ static void __put_nfs_open_context(struct >>> nfs_open_context *ctx, int is_sync) >>> struct inode *inode = ctx->dentry->d_inode; >>> struct super_block *sb = ctx->dentry->d_sb; >>> >>> + if (ctx == NULL) >>> + return; >>> + >>> if (!list_empty(&ctx->list)) { >>> if (!atomic_dec_and_lock(&ctx->lock_context.count, >>> &inode->i_lock)) >>> return; >>> -- >>> 1.8.3.1 >>> >> >> AFAICS, there is only one callsite where we need to check the context, so we >> can avoid the check on all calls to put_nfs_open_context. Please see PATCH >> 1/2 that I just posted in response to an off-list bug report from Steve >> Dickson. Thanks Trond, Both patches should fix the OOPS, but I think your reasoning to avoid the check in all calls to put_nfs_open_context makes sense. -dros >> >> Cheers >> Trond >> -- >> >> Trond Myklebust >> >> Linux NFS client maintainer, PrimaryData >> >> trond.myklebust@primarydata.com > > > > -- > Trond Myklebust > > Linux NFS client maintainer, PrimaryData > > trond.myklebust@primarydata.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html