Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:24425 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751063AbaJANtv (ORCPT ); Wed, 1 Oct 2014 09:49:51 -0400 Message-ID: <542C067C.7030309@Netapp.com> Date: Wed, 1 Oct 2014 09:49:48 -0400 From: Anna Schumaker MIME-Version: 1.0 To: Trond Myklebust , Subject: Re: [PATCH v2 1/2] NFSv4: Fix lock recovery when CREATE_SESSION/SETCLIENTID_CONFIRM fails References: <1411876498-12039-1-git-send-email-trond.myklebust@primarydata.com> <1411876498-12039-2-git-send-email-trond.myklebust@primarydata.com> In-Reply-To: <1411876498-12039-2-git-send-email-trond.myklebust@primarydata.com> Content-Type: text/plain; charset="utf-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: On 09/27/2014 11:54 PM, Trond Myklebust wrote: > If a NFSv4.x server returns NFS4ERR_STALE_CLIENTID in response to a > CREATE_SESSION or SETCLIENTID_CONFIRM in order to tell us that it rebooted > a second time, then the client will currently take this to mean that it must > declare all locks to be stale, and hence ineligible for reboot recovery. > > RFC3530 and RFC5661 both suggest that the client should instead rely on the > server to respond to inelegible open share, lock and delegation reclaim > requests with NFS4ERR_NO_GRACE in this situation. Has our handling of NFS4ERR_NO_GRACE been tested in this situation? Anna > > Cc: stable@vger.kernel.org > Signed-off-by: Trond Myklebust > --- > fs/nfs/nfs4state.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c > index 22fe35104c0c..26d510d11efd 100644 > --- a/fs/nfs/nfs4state.c > +++ b/fs/nfs/nfs4state.c > @@ -1761,7 +1761,6 @@ static int nfs4_handle_reclaim_lease_error(struct nfs_client *clp, int status) > break; > case -NFS4ERR_STALE_CLIENTID: > clear_bit(NFS4CLNT_LEASE_CONFIRM, &clp->cl_state); > - nfs4_state_clear_reclaim_reboot(clp); > nfs4_state_start_reclaim_reboot(clp); > break; > case -NFS4ERR_CLID_INUSE: