Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:8606 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967AbaKJOgG (ORCPT ); Mon, 10 Nov 2014 09:36:06 -0500 Message-ID: <5460CD53.1080301@Netapp.com> Date: Mon, 10 Nov 2014 09:36:03 -0500 From: Anna Schumaker MIME-Version: 1.0 To: Chuck Lever , , Subject: Re: [PATCH v2 06/10] xprtrdma: Enable pad optimization References: <20141109010328.8806.5861.stgit@manet.1015granger.net> <20141109011453.8806.31817.stgit@manet.1015granger.net> In-Reply-To: <20141109011453.8806.31817.stgit@manet.1015granger.net> Content-Type: text/plain; charset="utf-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: Hey Chuck, On 11/08/2014 08:14 PM, Chuck Lever wrote: > The Linux NFS/RDMA server used to reject NFSv3 WRITE requests when > pad optimization was enabled. That bug was fixed by commit > e560e3b510d2 ("svcrdma: Add zero padding if the client doesn't send > it"). Do we need to worry about backwards compatibility with servers that don't have this patch? Anna > > We can now enable pad optimization on the client, which helps > performance and is supported now by both Linux and Solaris servers. > > Signed-off-by: Chuck Lever > --- > net/sunrpc/xprtrdma/transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c > index cfe9a81..8ed2576 100644 > --- a/net/sunrpc/xprtrdma/transport.c > +++ b/net/sunrpc/xprtrdma/transport.c > @@ -73,7 +73,7 @@ static unsigned int xprt_rdma_max_inline_read = RPCRDMA_DEF_INLINE; > static unsigned int xprt_rdma_max_inline_write = RPCRDMA_DEF_INLINE; > static unsigned int xprt_rdma_inline_write_padding; > static unsigned int xprt_rdma_memreg_strategy = RPCRDMA_FRMR; > - int xprt_rdma_pad_optimize = 0; > + int xprt_rdma_pad_optimize = 1; > > #ifdef RPC_DEBUG > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html