Message-ID: <548C5E58.2000100@RedHat.com>
Date: Sat, 13 Dec 2014 10:42:16 -0500
From: Steve Dickson <SteveD@redhat.com>
MIME-Version: 1.0
To: Scott Mayhew <smayhew@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH v4 00/14] A few enhancements to mountstats.py
References: <1418411697-65535-1-git-send-email-smayhew@redhat.com>
In-Reply-To: <1418411697-65535-1-git-send-email-smayhew@redhat.com>
Content-Type: text/plain; charset=windows-1252
Sender: linux-nfs-owner@vger.kernel.org


On 12/12/2014 02:14 PM, Scott Mayhew wrote:
> These are also available in the 'mountstats-improvements-v4' branch at
> https://github.com/scottmayhew/nfs-utils.git
> 
> v4 changes:
> 
> - SteveD was not a fan of the ms-iostat and ms-nfsstat command names. 
>   Rather than think up new names, I decided to make these all sub-commands.
>   If no sub-command is given by the user then the 'mountstats' sub-command
>   will run by default (so any existing scripts that run older versions of
>   the mountstats command should still work).
> 
> - Rather than have 3 tiny man pages, I documented the main command and the
>   three sub-commands on a single man page.
> 
> v3 changes:
> 
> - Rebased on top of the lastest mountstats version
> 
> - Added exception processing to fail more gracefully when the argparse
>   module is not installed
> 
> - Corrected some issues with the man pages (filenames not italicized,
>   unmatched braces in the synopses)
> 
> v2 changes:
> 
> - Changed the parsing to use the argparse module instead of optparse
> 
> - Added per-mountpoint headers to the output of 'mountstats --rpc'
> 
> - Revamped the ms-nfsstat command to take a variable list of mountpoints
>   (so now mountstats, ms-iostat, and ms-nfsstat all behave in the same
>   manner).  Added -3 and -4 options which behave the same way they do in
>   nfsstat.c.  The output doesn't still doesn't match up 100% with that
>   of nfsstat.c though (I'm just taking the first 12 characters of the
>   operation name and converting them to lowercase to use as labels, while
>   nfsstat.c defines its own labels, but also it looks to me like nfsstat.c
>   is missing some operations altoegether).
> 
> - Updated the man page for mountstats and added man pages for ms-iostat
>   and ms-nfsstat.
> 
> Original cover letter:
> 
> -------------------8<------------------
> 
> The following patches add a couple of enhancements to mountstats.py.  I
> also fixed a few bugs I encountered along the way.  Highlights include:
> 
> - added support for -f/--file to allow stats to be parsed from an
>   aritrary input file instead of /proc/self/mountstats
> 
> - added support for -S/--since to show just the changes that have
>   occurred between the current and a previous set of statisics (works
>   with and without the -f option)
> 
> - added support for -R/--raw to generate 'raw' statistics (i.e. in the
>   same format as /proc/self/mountstats).  It's intended to be used with
>   the -f and -S options.
> 
> - implemented the ms-nfsstat command to generate client-side
>   nfsstat-like statisics (only works with a single mountpoint)
> 
> My motivation for these changes was so that I could take various copies
> of /proc/self/mountstats and massage them into data that I could feed
> into the 'report' option of Dros's nfsometer tool for scenarios where
> it's not feasible to run nfsometer itself (e.g. systems where we can't
> start with an 'idle' state (i.e. no NFS filesystems initially
> mounted), systems with multiple NFS filesystems mounted, and workloads
> that can't easily be boiled down into an nfsometer workload file or run
> via the custom workload environment variables).
> 
> Scott Mayhew (14):
>   mountstats: Fix up NFS event counters
>   mountstats: Add lists of various counters
>   mountstats: Refactor __parse_nfs_line and __parse_rpc_line
>   mountstats: Refactor compare_iostats
>   mountstats: Convert existing option parsing to use the argparse module
>   mountstats: Make the iostat sub-command output match that of
>     nfs-iostat.py
>   mountstats: Make print_iostat_summary handle newly appearing mounts
>   mountstats: Add support for -f/--file
>   mountstats: Add support for -S/--since
>   mountstats: Fix IndexError in __parse_nfs_line
>   mountstats: Allow mountstats_command to take a variable number of
>     mountpoints
>   mountstats: Add support for -R/--raw to mountstats_command
>   mountstats: Implement the nfsstat sub-command
>   mountstats: Updated the mountstats(8) man page.
> 
>  tools/mountstats/mountstats.man | 142 +++++-
>  tools/mountstats/mountstats.py  | 927 ++++++++++++++++++++++++++++------------
>  2 files changed, 775 insertions(+), 294 deletions(-)
> 
Committed... 

steved.