Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-vc0-f172.google.com ([209.85.220.172]:62996 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752402AbbANRNo convert rfc822-to-8bit (ORCPT ); Wed, 14 Jan 2015 12:13:44 -0500 Received: by mail-vc0-f172.google.com with SMTP id hq11so3275036vcb.3 for ; Wed, 14 Jan 2015 09:13:43 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1421249572-12038-1-git-send-email-jlayton@primarydata.com> References: <1421249572-12038-1-git-send-email-jlayton@primarydata.com> Date: Wed, 14 Jan 2015 12:13:43 -0500 Message-ID: Subject: Re: [PATCH] nfs: don't call blocking operations while !TASK_RUNNING From: Trond Myklebust To: Jeff Layton Cc: Bruce Fields , Linux NFS Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Jan 14, 2015 at 10:32 AM, Jeff Layton wrote: > Bruce reported seeing this warning pop when mounting using v4.1: > > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 1121 at kernel/sched/core.c:7300 __might_sleep+0xbd/0xd0() > do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+0x2f/0x90 > Modules linked in: rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace sunrpc fscache ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw snd_hda_codec_generic snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm snd_timer ppdev joydev snd virtio_console virtio_balloon pcspkr serio_raw parport_pc parport pvpanic floppy soundcore i2c_piix4 virtio_blk virtio_net qxl drm_kms_helper ttm drm virtio_pci virtio_ring ata_generic virtio pata_acpi > CPU: 1 PID: 1121 Comm: nfsv4.1-svc Not tainted 3.19.0-rc4+ #25 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140709_153950- 04/01/2014 > 0000000000000000 000000004e5e3f73 ffff8800b998fb48 ffffffff8186ac78 > 0000000000000000 ffff8800b998fba0 ffff8800b998fb88 ffffffff810ac9da > ffff8800b998fb68 ffffffff81c923e7 00000000000004d9 0000000000000000 > Call Trace: > [] dump_stack+0x4c/0x65 > [] warn_slowpath_common+0x8a/0xc0 > [] warn_slowpath_fmt+0x55/0x70 > [] ? prepare_to_wait+0x2f/0x90 > [] ? prepare_to_wait+0x2f/0x90 > [] __might_sleep+0xbd/0xd0 > [] kmem_cache_alloc_trace+0x243/0x430 > [] ? groups_alloc+0x3e/0x130 > [] groups_alloc+0x3e/0x130 > [] svcauth_unix_accept+0x16e/0x290 [sunrpc] > [] svc_authenticate+0xe1/0xf0 [sunrpc] > [] svc_process_common+0x244/0x6a0 [sunrpc] > [] bc_svc_process+0x1c4/0x260 [sunrpc] > [] nfs41_callback_svc+0x128/0x1f0 [nfsv4] > [] ? wait_woken+0xc0/0xc0 > [] ? nfs4_callback_svc+0x60/0x60 [nfsv4] > [] kthread+0x11f/0x140 > [] ? local_clock+0x15/0x30 > [] ? kthread_create_on_node+0x250/0x250 > [] ret_from_fork+0x7c/0xb0 > [] ? kthread_create_on_node+0x250/0x250 > ---[ end trace 675220a11e30f4f2 ]--- > > nfs41_callback_svc does most of its work while in TASK_INTERRUPTIBLE, > which is just wrong. Fix that by finishing the wait immediately if we've > found that the list has something on it. ACK. > Also, we don't expect this kthread to accept signals, so we should be > using a TASK_UNINTERRUPTIBLE sleep instead. Umm... Won't that end up triggering the hung task watchdog for every 120seconds with no callback activity? > Reported-by: "J. Bruce Fields" > Signed-off-by: Jeff Layton > --- > fs/nfs/callback.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c > index b8fb3a4ef649..ebba958e084c 100644 > --- a/fs/nfs/callback.c > +++ b/fs/nfs/callback.c > @@ -128,13 +128,14 @@ nfs41_callback_svc(void *vrqstp) > if (try_to_freeze()) > continue; > > - prepare_to_wait(&serv->sv_cb_waitq, &wq, TASK_INTERRUPTIBLE); > + prepare_to_wait(&serv->sv_cb_waitq, &wq, TASK_UNINTERRUPTIBLE); > spin_lock_bh(&serv->sv_cb_lock); > if (!list_empty(&serv->sv_cb_list)) { > req = list_first_entry(&serv->sv_cb_list, > struct rpc_rqst, rq_bc_list); > list_del(&req->rq_bc_list); > spin_unlock_bh(&serv->sv_cb_lock); > + finish_wait(&serv->sv_cb_waitq, &wq); > dprintk("Invoking bc_svc_process()\n"); > error = bc_svc_process(serv, req, rqstp); > dprintk("bc_svc_process() returned w/ error code= %d\n", > @@ -142,8 +143,8 @@ nfs41_callback_svc(void *vrqstp) > } else { > spin_unlock_bh(&serv->sv_cb_lock); > schedule(); > + finish_wait(&serv->sv_cb_waitq, &wq); > } > - finish_wait(&serv->sv_cb_waitq, &wq); > } > return 0; > } > -- > 2.1.0 > -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com