Return-Path: linux-nfs-owner@vger.kernel.org Received: from cantor2.suse.de ([195.135.220.15]:57336 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbbANNF0 (ORCPT ); Wed, 14 Jan 2015 08:05:26 -0500 Date: Wed, 14 Jan 2015 14:05:20 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , David Howells , Tejun Heo , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org Subject: Re: [PATCH 06/12] nilfs2: set up s_bdi like the generic mount_bdev code Message-ID: <20150114130520.GH10215@quack.suse.cz> References: <1421228561-16857-1-git-send-email-hch@lst.de> <1421228561-16857-7-git-send-email-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1421228561-16857-7-git-send-email-hch@lst.de> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed 14-01-15 10:42:35, Christoph Hellwig wrote: > mapping->backing_dev_info will go away, so don't rely on it. > > Signed-off-by: Christoph Hellwig > Acked-by: Ryusuke Konishi > Reviewed-by: Tejun Heo > --- > fs/nilfs2/super.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c > index 2e5b3ec..3d4bbac 100644 > --- a/fs/nilfs2/super.c > +++ b/fs/nilfs2/super.c > @@ -1077,8 +1076,7 @@ nilfs_fill_super(struct super_block *sb, void *data, int silent) > sb->s_time_gran = 1; > sb->s_max_links = NILFS_LINK_MAX; > > - bdi = sb->s_bdev->bd_inode->i_mapping->backing_dev_info; > - sb->s_bdi = bdi ? : &default_backing_dev_info; > + sb->s_bdi = &bdev_get_queue(sb->s_bdev)->backing_dev_info; Why don't you use blk_get_backing_dev_info() here? Otherwise the patch looks fine. So you can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR