Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-pd0-f176.google.com ([209.85.192.176]:37112 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760927AbbBIVaO convert rfc822-to-8bit (ORCPT ); Mon, 9 Feb 2015 16:30:14 -0500 Received: by pdbfl12 with SMTP id fl12so9229101pdb.4 for ; Mon, 09 Feb 2015 13:30:13 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: [PATCH] sunrpc: Give parameter names to rpc_count_iostasts_metrics() From: Tom Haynes In-Reply-To: <1423508838-1806-1-git-send-email-Anna.Schumaker@Netapp.com> Date: Mon, 9 Feb 2015 13:30:05 -0800 Cc: Trond.Myklebust@primarydata.com, linux-nfs@vger.kernel.org Message-Id: References: <1423508838-1806-1-git-send-email-Anna.Schumaker@Netapp.com> To: Anna Schumaker Sender: linux-nfs-owner@vger.kernel.org List-ID: > On Feb 9, 2015, at 11:07 AM, Anna Schumaker wrote: > > We fall back to an empty function in the case that CONFIG_PROC_FS=n, so > give this function named parameters to silence a "parameter name omitted" > warning. > > Reported-by: Jim Davis > Signed-off-by: Anna Schumaker > --- > include/linux/sunrpc/metrics.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/sunrpc/metrics.h b/include/linux/sunrpc/metrics.h > index 7e61a17..b23b8ed 100644 > --- a/include/linux/sunrpc/metrics.h > +++ b/include/linux/sunrpc/metrics.h > @@ -89,8 +89,8 @@ void rpc_free_iostats(struct rpc_iostats *); > static inline struct rpc_iostats *rpc_alloc_iostats(struct rpc_clnt *clnt) { return NULL; } > static inline void rpc_count_iostats(const struct rpc_task *task, > struct rpc_iostats *stats) {} Hi Anna, Why doesn’t the above also emit the warning? Thanks, Tom > -static inline void rpc_count_iostats_metrics(const struct rpc_task *, > - struct rpc_iostats *) {} > +static inline void rpc_count_iostats_metrics(const struct rpc_task *task, > + struct rpc_iostats *op_metrics) {} > static inline void rpc_print_iostats(struct seq_file *seq, struct rpc_clnt *clnt) {} > static inline void rpc_free_iostats(struct rpc_iostats *stats) {} > > -- > 2.3.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html