Return-Path: linux-nfs-owner@vger.kernel.org Received: from aserp1040.oracle.com ([141.146.126.69]:36822 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919AbbCBP54 convert rfc822-to-8bit (ORCPT ); Mon, 2 Mar 2015 10:57:56 -0500 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: File Read Returns Non-existent Null Bytes From: Chuck Lever In-Reply-To: Date: Mon, 2 Mar 2015 10:57:43 -0500 Cc: "J. Bruce Fields" , Trond Myklebust , Linux NFS Mailing List , Chris Perl Message-Id: References: <20150227224029.GA8750@fieldses.org> <0836BFA3-1F2D-4CD0-AB25-3DBA916D941C@oracle.com> To: Chris Perl Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Chris! Still in the context of deciding what should go in the FAQ, my comments are below. On Mar 2, 2015, at 10:19 AM, Chris Perl wrote: >> I?m in favor of staying more hand-wavy. Otherwise you will end up >> making promises you don?t intend to keep ;-) > > FWIW, I'm in favor of at least some specifics. Something stating that > the results of reading from a file while another client holds it open > for write are undefined (point 3 of what was already proposed). The language has to be very careful. Opens for write are used frequently and by themselves do not cause any damage. Corruption risk increases when actual writes occur, followed by reads of the same file on other clients, without a close and re-open. Also, any published statement about this could lock us into a particular behavior. That makes it harder to improve or change (say, to address a bug) in the future. Specifics can be discussed on the mailing list on a case-by-case basis. The specifics depend on a bunch of things, for example: - which clients are in play - which NFS version is in use (delegations and open state) - whether reading and writing is in the same byte range - whether the file size is changing - whether O_DIRECT and mapped files are in use And so on. There could also be real bugs, which would become apparent after discussion. A general (and more explicit) warning about write sharing is appropriate to add. I feel it would be difficult to get the specifics right. I could add something to A8 that says ?Detailed questions can be directed to linux-nfs@vger.kernel.org.? Do you feel you got a good answer from the mailing list? -- Chuck Lever chuck[dot]lever[at]oracle[dot]com