Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-ig0-f179.google.com ([209.85.213.179]:33475 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754624AbbCBUxL (ORCPT ); Mon, 2 Mar 2015 15:53:11 -0500 Received: by igbhl2 with SMTP id hl2so19336857igb.0 for ; Mon, 02 Mar 2015 12:53:10 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 2 Mar 2015 15:53:10 -0500 Message-ID: Subject: Re: buggy CLOSE in the "testing" branch From: Olga Kornievskaia To: Trond Myklebust Cc: linux-nfs Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Mar 2, 2015 at 3:47 PM, Trond Myklebust wrote: > Hi Olga, > > On Mon, Mar 2, 2015 at 3:15 PM, Olga Kornievskaia wrote: >> Hi folks, >> >> I'm experiencing that CLOSE uses a delegation stateid instead of the >> open stateid which I think is what the spec says. Server replies with >> BAD_STATEID. >> >> Is this a bug or did I misread the spec? Thanks. >> > > That would be a client bug. Do you have a reproducer? Yep. Just cat a (2nd) file after mount (i.e.., a file needs to have a delegation). A CLOSE will use a delegation stateid. Problem is seenl on the network trace. It will also leads to failure on unmount with CLIENTID_BUSY because there is still an open state that client never released. Please note that both "cat" and "unmount" will "succeed" from the user's perspective. Thus, unless testing also looks at the network trace, this failure will never be caught. > > -- > Trond Myklebust > Linux NFS client maintainer, PrimaryData > trond.myklebust@primarydata.com