Return-Path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:32852 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933258AbbCYPJl (ORCPT ); Wed, 25 Mar 2015 11:09:41 -0400 Received: by wgbcc7 with SMTP id cc7so30833492wgb.0 for ; Wed, 25 Mar 2015 08:09:39 -0700 (PDT) Message-ID: <5512CFB0.1050108@profitbricks.com> Date: Wed, 25 Mar 2015 16:09:36 +0100 From: Michael Wang MIME-Version: 1.0 To: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, Roland Dreier , Sean Hefty , Hal Rosenstock , Ira Weiny CC: Trond Myklebust , "J. Bruce Fields" , "David S. Miller" , Moni Shoua , Or Gerlitz , Tatyana Nikolova , Steve Wise , Yan Burman , Jack Morgenstein , Bart Van Assche , Yann Droneaud , Colin Ian King , Jiri Kosina , Matan Barak , Majd Dibbiny , Dan Carpenter , Mel Gorman , Alex Estrin , Doug Ledford , Eric Dumazet , Erez Shitrit , Sagi Grimberg , Haggai Eran , Shachar Raindel , Mike Marciniszyn , Tom Tucker , Chuck Lever , Michael Wang Subject: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer Content-Type: text/plain; charset=utf-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: My sincerely apologies for the corrupted mails, and thanks for Dan's kindly remind :-) There are too many lengthy code to check the transport type of IB device, or the link layer type of it's port, this patch set try to use some helper to refine and save us some code. TODO: Currently we inferred from the transport type and link layer type to identify the way of management, it will be better if we can directly get the indicator from vendor. Sean proposed one suggestion: https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23339.html It may need a big work to adapt current implementation to utilize these flags elegantly. Also the performance concern on query_port() need to be addressed, may be some new callback like query_mgmt() could works. Michael Wang (2): [PATCH 1/2] IB/Verbs: Use helpers to check transport and link layer [PATCH 2/2] IB/Verbs: Use helpers to check IBoE technology --- drivers/infiniband/core/agent.c | 2 - drivers/infiniband/core/cm.c | 2 - drivers/infiniband/core/cma.c | 33 ++++++++++++------------------ drivers/infiniband/core/mad.c | 6 ++--- drivers/infiniband/core/multicast.c | 11 +++------- drivers/infiniband/core/sa_query.c | 14 ++++++------ drivers/infiniband/core/ucm.c | 3 -- drivers/infiniband/core/user_mad.c | 2 - drivers/infiniband/core/verbs.c | 5 +--- drivers/infiniband/hw/mlx4/ah.c | 2 - drivers/infiniband/hw/mlx4/cq.c | 4 --- drivers/infiniband/hw/mlx4/mad.c | 14 +++--------- drivers/infiniband/hw/mlx4/main.c | 8 ++----- drivers/infiniband/hw/mlx4/mlx4_ib.h | 2 - drivers/infiniband/hw/mlx4/qp.c | 21 ++++++------------- drivers/infiniband/hw/mlx4/sysfs.c | 6 +---- drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 ++--- include/rdma/ib_verbs.h | 30 +++++++++++++++++++++++++++ net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 3 -- 19 files changed, 87 insertions(+), 87 deletions(-)