Return-Path: Received: from mx142.netapp.com ([216.240.21.19]:33314 "EHLO mx142.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbbDHRxR (ORCPT ); Wed, 8 Apr 2015 13:53:17 -0400 Message-ID: <55256B09.4010501@Netapp.com> Date: Wed, 8 Apr 2015 13:53:13 -0400 From: Anna Schumaker MIME-Version: 1.0 To: Trond Myklebust CC: Steve Dickson , Linux NFS Mailing List Subject: Re: [PATCH 0/2] Mountstats Fixes References: <1428511647-14920-1-git-send-email-Anna.Schumaker@Netapp.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: On 04/08/2015 01:01 PM, Trond Myklebust wrote: > On Wed, Apr 8, 2015 at 12:47 PM, Anna Schumaker > wrote: >> I had some trouble using mountstats to analyze READ_PLUS operations, so I >> wrote these patches to fix my issues. >> >> I found that /proc/self/mountstats was reporting "GETDEVICELIST" as "51", > > Shouldn't we try to fix that as being a regression in the client? I > see no reason why we shouldn't be able to add in a p_name for > GETDEVICELIST. I'm cool with that. I wasn't sure if it fell under "don't break userspace" if I'm the only person to have a problem in however long it's been since GETDEVICELIST was removed. Anna > >> most likely because it was removed from the client but the nfs4_procedures >> array still has a placeholder for it. Mountstats crashes when it tries to >> analyze "51", so the second patch fixes this issue by looking for numeric >> operation names. I'm willing to put in stubs for GETDEVICELIST back into >> the client if that would be a better fix. >> >> Thanks, >> Anna >> >> >> Anna Schumaker (2): >> mountstats: Resync NFSv4 Operations List >> mountstats: Only count operations that have names >> >> tools/mountstats/mountstats.py | 13 ++++++++----- >> 1 file changed, 8 insertions(+), 5 deletions(-) >> >> -- >> 2.3.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html