Return-Path: Received: from mx144.netapp.com ([216.240.21.25]:38745 "EHLO mx144.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932412AbbDNRQi (ORCPT ); Tue, 14 Apr 2015 13:16:38 -0400 Message-ID: <552D4B5D.3090904@Netapp.com> Date: Tue, 14 Apr 2015 13:16:13 -0400 From: Anna Schumaker MIME-Version: 1.0 To: Christoph Hellwig , Jeff Layton CC: Trond Myklebust , Zach Brown , Linux Kernel Mailing List , Linux FS-devel Mailing List , , Linux NFS Mailing List , Subject: Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper References: <1428703236-24735-1-git-send-email-zab@redhat.com> <1428703236-24735-2-git-send-email-zab@redhat.com> <20150411000208.GA20949@lenny.home.zabbo.net> <20150411090402.67d22d02@tlielax.poochiereds.net> <20150414165344.GA21421@infradead.org> In-Reply-To: <20150414165344.GA21421@infradead.org> Content-Type: text/plain; charset="utf-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: On 04/14/2015 12:53 PM, Christoph Hellwig wrote: > On Sat, Apr 11, 2015 at 09:04:02AM -0400, Jeff Layton wrote: >> Yuck! How the heck do you clean up the mess if that happens? I guess >> you're just stuck redoing the copy with normal READ/WRITE? >> >> Maybe we need to have the interface return a hard error in that >> case and not try to give back any sort of offset? > > The NFSv4.2 COPY interface is a train wreck. At least for Linux I'd > expect us to simply ignore it and only implement my new CLONE operation > with sane semantics. That is unless someone can show some real life > use case for the inter server copy, in which case we'll have to deal > with that mess. But getting that one right at the VFS level will > be a nightmare anyway. > > Make this a vote from me to not support partial copies and just return > and error in that case. Agreed. Looking at the v4.2 spec, COPY does take ca_consecutive and a ca_synchronous flags that let the client state if the copy should be done consecutively or synchronously. I expected to always set consecutive to "true" for the Linux client. Anna > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >