Return-Path: Message-ID: <554A18D6.6070903@gmail.com> Date: Wed, 06 May 2015 21:36:22 +0800 From: Kinglong Mee MIME-Version: 1.0 To: Steve Dickson CC: Benjamin Coddington , "linux-nfs@vger.kernel.org" , kinglongmee@gmail.com Subject: Re: [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 References: <552A5F3F.1090206@gmail.com> <552BB4DF.2090200@gmail.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 List-ID: On 4/13/2015 8:43 PM, Benjamin Coddington wrote: > On Mon, 13 Apr 2015, Kinglong Mee wrote: > >> On 4/13/2015 8:16 PM, Benjamin Coddington wrote: >>> Hi Kinglong, I can't seem to figure out how to reproduce your problem, and >>> I don't see show this change fixes it. Your mount is falling back to a v3 >>> attempt without this patch? What's set in nfsmount.conf? >> >> Sorry for my missing notes for nfsmount.conf. >> My nfsmount.conf is default config, >> besides [ NFSMount_Global_Options ], others line are commented by "#", >> Defaultvers isn't set as, "# Defaultvers=4" >> >> thanks, >> Kinglong Mee > > Yes, I see the problem now. The version strings were stripped and never > added back in the general case. Thank you. This looks right. > > Reviewed-by: Benjamin Coddington Hello Steve, What's the status of this patch? thanks, Kinglong Mee > >>> On Sun, 12 Apr 2015, Kinglong Mee wrote: >>> >>>> When mounting nfs with -ov4, -overs=4 or -onfsvers=4, fail as, >>>> >>>> # mount -t nfs -ov4 192.168.31.12:/ /testidr/ >>>> mount.nfs: access denied by server while mounting 192.168.31.12:/ >>>> >>>> Fixes: f980298853 "mount.nfs: configurable minor version defaults" >>>> Signed-off-by: Kinglong Mee >>>> --- >>>> utils/mount/stropts.c | 12 +++--------- >>>> 1 file changed, 3 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c >>>> index df67fac..2ae532e 100644 >>>> --- a/utils/mount/stropts.c >>>> +++ b/utils/mount/stropts.c >>>> @@ -108,12 +108,6 @@ static void nfs_default_version(struct nfsmount_info *mi) >>>> return; >>>> } >>>> >>>> - if (mi->version.v_mode == V_GENERAL && >>>> - config_default_vers.v_mode == V_DEFAULT) { >>>> - mi->version.v_mode = V_SPECIFIC; >>>> - return; >>>> - } >>>> - >>>> if (mi->version.v_mode == V_DEFAULT && >>>> config_default_vers.v_mode != V_DEFAULT) { >>>> mi->version.major = config_default_vers.major; >>>> @@ -121,9 +115,9 @@ static void nfs_default_version(struct nfsmount_info *mi) >>>> return; >>>> } >>>> >>>> - if (mi->version.v_mode == V_GENERAL && >>>> - config_default_vers.v_mode != V_DEFAULT) { >>>> - if (mi->version.major == config_default_vers.major) >>>> + if (mi->version.v_mode == V_GENERAL) { >>>> + if (config_default_vers.v_mode != V_DEFAULT && >>>> + mi->version.major == config_default_vers.major) >>>> mi->version.minor = config_default_vers.minor; >>>> return; >>>> } >>>> -- >>>> 2.3.5 >>>> >>>> >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >