Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:53299 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbbEGORb (ORCPT ); Thu, 7 May 2015 10:17:31 -0400 Message-ID: <554B73FA.8080106@RedHat.com> Date: Thu, 07 May 2015 10:17:30 -0400 From: Steve Dickson MIME-Version: 1.0 To: Kinglong Mee CC: "linux-nfs@vger.kernel.org" , smayhew@redhat.com Subject: Re: [PATCH] rpc.mountd: Remove duplicate and invalid secinfo setting References: <552FB045.80604@gmail.com> In-Reply-To: <552FB045.80604@gmail.com> Content-Type: text/plain; charset=utf-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 04/16/2015 08:51 AM, Kinglong Mee wrote: > NFSD return reply of client's SECINFO_NO_NAME request with four > security information number as, 1 1 0 0 > > It's caused by commit 4a1ad4aa30, > "mountd: Enable all auth flavors on pseudofs exports" > > This patch removes duplicate secinfo and invalid secinfo (zero). > > Signed-off-by: Kinglong Mee > --- > support/nfs/exports.c | 2 +- > utils/mountd/v4root.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) Committed... steved. > > diff --git a/support/nfs/exports.c b/support/nfs/exports.c > index 761a046..0aea6f1 100644 > --- a/support/nfs/exports.c > +++ b/support/nfs/exports.c > @@ -408,7 +408,7 @@ int secinfo_addflavor(struct flav_info *flav, struct exportent *ep) > struct sec_entry *p; > > for (p=ep->e_secinfo; p->flav; p++) { > - if (p->flav == flav) > + if (p->flav == flav || p->flav->fnum == flav->fnum) > return p - ep->e_secinfo; > } > if (p - ep->e_secinfo >= SECFLAVOR_COUNT) { > diff --git a/utils/mountd/v4root.c b/utils/mountd/v4root.c > index 429ebb8..d521725 100644 > --- a/utils/mountd/v4root.c > +++ b/utils/mountd/v4root.c > @@ -69,6 +69,9 @@ set_pseudofs_security(struct exportent *pseudo, int flags) > for (flav = flav_map; flav < flav_map + flav_map_size; flav++) { > struct sec_entry *new; > > + if (!flav->fnum) > + continue; > + > i = secinfo_addflavor(flav, pseudo); > new = &pseudo->e_secinfo[i]; > >