Return-Path: Received: from mx142.netapp.com ([216.240.21.19]:5533 "EHLO mx142.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932809AbbELSOF (ORCPT ); Tue, 12 May 2015 14:14:05 -0400 Message-ID: <555242E8.4050007@Netapp.com> Date: Tue, 12 May 2015 14:14:00 -0400 From: Anna Schumaker MIME-Version: 1.0 To: Chuck Lever , , Subject: Re: [PATCH v2 02/16] xprtrdma: Warn when there are orphaned IB objects References: <20150511174401.31263.79596.stgit@manet.1015granger.net> <20150511180235.31263.71754.stgit@manet.1015granger.net> In-Reply-To: <20150511180235.31263.71754.stgit@manet.1015granger.net> Content-Type: text/plain; charset="utf-8" Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Chuck, On 05/11/2015 02:02 PM, Chuck Lever wrote: > WARN during transport destruction if ib_dealloc_pd() fails. This is > a sign that xprtrdma orphaned one or more RDMA API objects at some > point, which can pin lower layer kernel modules and cause shutdown > to hang. I'm curious, what would cause the API objects to get orphaned in the first place? Is there any way to prevent it? Anna > > Signed-off-by: Chuck Lever > Reviewed-by: Steve Wise > Reviewed-by: Sagi Grimberg > Reviewed-by: Devesh Sharma > --- > net/sunrpc/xprtrdma/verbs.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c > index 4870d27..51900e6 100644 > --- a/net/sunrpc/xprtrdma/verbs.c > +++ b/net/sunrpc/xprtrdma/verbs.c > @@ -702,17 +702,17 @@ rpcrdma_ia_close(struct rpcrdma_ia *ia) > dprintk("RPC: %s: ib_dereg_mr returned %i\n", > __func__, rc); > } > + > if (ia->ri_id != NULL && !IS_ERR(ia->ri_id)) { > if (ia->ri_id->qp) > rdma_destroy_qp(ia->ri_id); > rdma_destroy_id(ia->ri_id); > ia->ri_id = NULL; > } > - if (ia->ri_pd != NULL && !IS_ERR(ia->ri_pd)) { > - rc = ib_dealloc_pd(ia->ri_pd); > - dprintk("RPC: %s: ib_dealloc_pd returned %i\n", > - __func__, rc); > - } > + > + /* If the pd is still busy, xprtrdma missed freeing a resource */ > + if (ia->ri_pd && !IS_ERR(ia->ri_pd)) > + WARN_ON(ib_dealloc_pd(ia->ri_pd)); > } > > /* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >