Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:59517 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbbFKIUb (ORCPT ); Thu, 11 Jun 2015 04:20:31 -0400 Date: Thu, 11 Jun 2015 01:20:28 -0700 From: Christoph Hellwig To: Kinglong Mee Cc: Trond Myklebust , "linux-nfs@vger.kernel.org" , Weston Andros Adamson , "J. Bruce Fields" Subject: Re: [PATCH 1/2] nfs: Only update callback sequnce id when CB_SEQUENCE success Message-ID: <20150611082028.GA11330@infradead.org> References: <556D8C66.8080203@gmail.com> <5578E67C.1030303@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <5578E67C.1030303@gmail.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: Hi Kinglong, when we last brought up this issue the recommendation was to follow the model in the clients nfs41_sequence_done() which handles even more corner cases. Given that my previous fixes in that area were just a bandaid I probably shouldn't complain about piece mail handling, but if you have a little spare time available implementing the full set of checks might be worthwhile.