Return-Path: Received: from mail-ig0-f179.google.com ([209.85.213.179]:37115 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbbFSBrt (ORCPT ); Thu, 18 Jun 2015 21:47:49 -0400 Received: by igblr2 with SMTP id lr2so4282708igb.0 for ; Thu, 18 Jun 2015 18:47:48 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20150618161727.1b4e287f@tlielax.poochiereds.net> References: <1434466052-10491-1-git-send-email-tao.peng@primarydata.com> <20150618161727.1b4e287f@tlielax.poochiereds.net> From: Peng Tao Date: Fri, 19 Jun 2015 09:47:28 +0800 Message-ID: Subject: Re: [PATCH 00/11] pnfs/flexfiles: layoutstats support To: Jeff Layton Cc: linux-nfs Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, Jun 19, 2015 at 4:17 AM, Jeff Layton wrote: > On Tue, 16 Jun 2015 22:47:21 +0800 > Peng Tao wrote: > >> Hi all, >> >> The patchsets add LAYOUTSTATS support to flexfiles. LAYOUTSTATS are sent >> every minute if IO is still happening upon a file. >> >> One limitation is that at most 4 LAYOUTSTATS calls are permitted in a compound. >> Had to send multiple LAYOUTSTATS operations per compound because OP_LAYOUTSTATS >> requires stateid and deviceid as its arguments, which makes it a per-file per-deviceid >> call. >> > > So what happens if there are more than 4 mirrors? Do you send more > LAYOUTSTATS rpcs or do the other ones get left out? I couldn't quite > tell that from looking over the code... > Only the first four mirrors' stats are sent out. The rest are left out. It is in ff_layout_prepare_layoutstats(). >> Cheers, >> Tao >> >> Peng Tao (8): >> pNFS: fill in nfs42_layoutstat_ops >> pnfs: add pnfs_report_layoutstat helper function >> pNFS/flexfiles: track when layout is first used >> pnfs/flexfiles: add ff_layout_prepare_layoutstats >> pnfs/flexfiles: encode LAYOUTSTATS flexfiles specific data >> pnfs/flexfiles: reset IO statistics upon LAYOUTSTATS success >> nfs42: serialize LAYOUTSTATS calls of the same file >> pnfs/flexfiles: report layoutstat regularly >> >> Trond Myklebust (3): >> NFSv.2/pnfs Add a LAYOUTSTATS rpc function >> pNFS/flexfiles: Remove unused struct members user_name, group_name >> pNFS/flexfiles: add layoutstats tracking >> >> fs/nfs/flexfilelayout/flexfilelayout.c | 448 ++++++++++++++++++++++++++++++++- >> fs/nfs/flexfilelayout/flexfilelayout.h | 30 ++- >> fs/nfs/nfs42.h | 7 +- >> fs/nfs/nfs42proc.c | 81 ++++++ >> fs/nfs/nfs42xdr.c | 122 +++++++++ >> fs/nfs/nfs4_fs.h | 1 + >> fs/nfs/nfs4proc.c | 4 +- >> fs/nfs/nfs4xdr.c | 1 + >> fs/nfs/pnfs.c | 56 +++++ >> fs/nfs/pnfs.h | 3 + >> include/linux/nfs4.h | 1 + >> include/linux/nfs_fs.h | 1 + >> include/linux/nfs_xdr.h | 43 ++++ >> 13 files changed, 782 insertions(+), 16 deletions(-) >> > > Nice work, Tao. This looks pretty good to me. I had a couple of > nitpicky comments, but that's stuff that can wait unless you need to > respin for other reasons. > > You can add my: > > Reviewed-by: Jeff Layton Thanks Jeff! Cheers, Tao